2019069 - Split interventions.json up into individual JSON files to make it easier to land intervention patches.

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, enhancement)

Description

[Thomas Wisniewski [:twisniewski]]

With interventions.json being one big file, it's difficult to land multiple interventions simultaneously without them depending on one another. This is one of the two procedural pain-points left for writing interventions, so let's remove it.

Instead let's split each intervention's JSON config out into its own file, and build run.js from those. That will give us some minor wins in addition to letting folks land intervention patches in any order.

Comment 1

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2019069 - part 1: generate the webcompat addon run.js at build-time from all JSON files in data/interventions; r?denschub,nalexander

Comment 2

[Thomas Wisniewski [:twisniewski]]

I will upload part 2 after the stack with this patch finishes landing.

Comment 3

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 2019069 - part 2: actually replace interventions.json with individualized JSON files per intervention; r?denschub

Comment 4

[Thomas Wisniewski [:twisniewski]]

https://treeherder.mozilla.org/jobs?repo=try&revision=8239b2d2bbc2aec1b4243670324546d5963959fb

Try looks green to me now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/463705816de6
https://hg.mozilla.org/integration/autoland/rev/5019cdc9554f
part 1: generate the webcompat addon run.js at build-time from all JSON files in data/interventions; r=nalexander,geckoview-reviewers,android-reviewers,frontend-codestyle-reviewers,mossop
https://github.com/mozilla-firefox/firefox/commit/5ebf41e7f42b
https://hg.mozilla.org/integration/autoland/rev/a5c39bd8a082
part 2: actually replace interventions.json with individualized JSON files per intervention; r=webcompat-reviewers,ksenia

Comment 6

[Aaron Train [:aaronmt]]

Attachment: Screenshot 2026-03-04 at 3.40.53 PM.png

Seeing a completely blank intervention list on Fenix/Focus debug builds on auto-land with this. Which the ui-test does not expect @ org.mozilla.fenix.ui.AboutURITest#verifyWebCompatPageIsLoadingTest

https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=ui-&revision=f67ef2becb9a6601c9cda29b92ea49b8a8a3dbb9&selectedTaskRun=dyoObfUJTY26Vz-9q7-jQg.0

Comment 7

[Aaron Train [:aaronmt]]

Attachment: Screenshot 2026-03-04 at 3.48.34 PM.png

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/78f7778559f0
https://hg.mozilla.org/integration/autoland/rev/c011b366e23d
Revert "Bug 2019069 - part 2: actually replace interventions.json with individualized JSON files per intervention; r=webcompat-reviewers,ksenia" for causing failures at WebCompatPage.

Comment 9

[Atila Butkovits]

Backed out for causing failures at WebCompatPage.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c011b366e23d

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f67ef2becb9a6601c9cda29b92ea49b8a8a3dbb9&selectedTaskRun=Py0BeKnHT1WE9ybIotcGnA.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=551897809&repo=autoland&task=Py0BeKnHT1WE9ybIotcGnA.0&lineNumber=353
https://treeherder.mozilla.org/logviewer?job_id=551892337&repo=autoland&task=diEXKzIoRpGAmZz6ZcsdkA.0&lineNumber=303

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3cd1dc66669a
https://hg.mozilla.org/integration/autoland/rev/d65d3e499f01
part 1: generate the webcompat addon run.js at build-time from all JSON files in data/interventions; r=nalexander,geckoview-reviewers,android-reviewers,frontend-codestyle-reviewers,mossop
https://github.com/mozilla-firefox/firefox/commit/0c4c29bc78fa
https://hg.mozilla.org/integration/autoland/rev/4fb538073a65
part 2: actually replace interventions.json with individualized JSON files per intervention; r=webcompat-reviewers,ksenia

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6979a436a887
https://hg.mozilla.org/integration/autoland/rev/068ba72f2e08
Revert "Bug 2019069 - part 2: actually replace interventions.json with individualized JSON files per intervention; r=webcompat-reviewers,ksenia" for causing Toolchain bustages.

Comment 12

[Atila Butkovits]

Backed out for causing Toolchain bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/068ba72f2e08

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4fb538073a6546205852dbe4655642bd3221d1e0

Failure logs:

https://treeherder.mozilla.org/logviewer?job_id=556429930&repo=autoland&task=dvwEc4F6Q6SR3vxzTym3OQ.0&lineNumber=799

Comment 13

[Thomas Wisniewski [:twisniewski]]

I don't know what could have caused that bustage, but I just rebased my patches and a try-run with that task seems fine: https://treeherder.mozilla.org/jobs?repo=try&revision=9ee5bad796665cd79b51a56f1ecfc2725bfbc0c5

So I'll try relanding the rebased versions soon.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3c7d20ed7f4f
https://hg.mozilla.org/integration/autoland/rev/726fa1a5b626
part 1: generate the webcompat addon run.js at build-time from all JSON files in data/interventions; r=nalexander,geckoview-reviewers,android-reviewers,frontend-codestyle-reviewers,mossop
https://github.com/mozilla-firefox/firefox/commit/ab721efd4c67
https://hg.mozilla.org/integration/autoland/rev/89d270dcc668
part 2: actually replace interventions.json with individualized JSON files per intervention; r=webcompat-reviewers,ksenia

Comment 15

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/726fa1a5b626
https://hg.mozilla.org/mozilla-central/rev/89d270dcc668