2019115 - Support Taskbar Tabs in Snap installations

Status: NEW

(Firefox :: Web Apps, enhancement, P1)

Description

[Duncan McIntosh [:dmcintosh]]

Bug 1982733 currently only handles non-sandboxed installations, it'd be good to make sure it works on Snap too for consistency. (I don't know much about Snap compared to Flatpak, presumably it should be pretty similar?)

Comment 1

[Duncan McIntosh [:dmcintosh]]

I was hoping this'd be dealt with in bug 2019113, but no such luck. xdg-desktop-portal determines whether a desktop file ID is valid through xdp_app_info_is_valid_sub_app_id, which defers to XdpAppInfo::is_valid_sub_app_id. In [edit: non-sandboxed], this allows everything; in Flatpak, this requires the sub-app-id to have a prefix of '<app-id>.' (which ours does!); in Snap... it's nullptr and returns false. Arghghhghhhhhh

Probably then the path forward is to submit a patch to xdg-desktop-portal implementing similar logic to Flatpak for Snap, or at least request this be documented somewhere. Not sure what the best move is for Snap before that lands in distros, or at least updated Ubuntu versions. (Can we detect the portal version client-side, I wonder?)

Changing to P1 since something has to be worked out, either disabling it or poking a sandbox hole or something.

Comment 2

[Duncan McIntosh [:dmcintosh]]

Guess I may as well assign myself too.

Comment 3

[Duncan McIntosh [:dmcintosh]]

I'll still try to get the underlying bugs in (i.e. disable snap for now, then add support maybe behind a pref), but the actual enablement will likely be someone else.

For that person, patch will look like changing the default desktop entry API on Snap to be 'filesystem'.