Display Blocked by AI Controls Info Message in about:translations
Categories
(Firefox :: Translations, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox150 | --- | fixed |
People
(Reporter: nordzilla, Assigned: nordzilla)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
Description
The about:translations design (internal only) needs to display an info message if the Translations feature is blocked by the AI controls.
The info message should also include an "Unblock" button that will unblock only the Translations feature and enable the page.
|
Assignee | |
Updated•3 months ago
|
|
|
Assignee | |
Updated•3 months ago
|
|
|
Assignee | |
Comment 1•3 months ago
|
||
This commit displays a new info message for when the Translations
feature is blocked by AI Controls. It includes an "Unblock" button
that will unblock the Translations feature for all of Firefox.
This top-level message bar is special in that the main UI remains
visible, but disabled, compared to all of the other top-level message
bars that ensure the main UI is hidden when they are shown.
|
|
Assignee | |
Comment 2•3 months ago
|
||
This commit displays a new info message for when the Translations
feature is blocked by AI Controls. It includes an "Unblock" button
that will unblock the Translations feature for all of Firefox.
This top-level message bar is special in that the main UI remains
visible, but disabled, compared to all of the other top-level message
bars that ensure the main UI is hidden when they are shown.
|
||
Updated•3 months ago
|
|
||
Comment 5•3 months ago
|
||
Backed out for causing bc failures @ browser_MLSuggest_integration.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/62f142991d0081d8034a0de8144efa867be51b1a
Failure log -> browser/components/urlbar/tests/browser/browser_MLSuggest_integration.js
|
|
Assignee | |
Comment 6•3 months ago
|
||
This is part of a single backout that spanned multiple bugs.
In the patch stack, I increased the timeout when waiting for a mocked RemoteSettings model to download within our Translations tests, hoping that it might also help to reduce intermittent Translations test failures.
There are a few ml related tests that share our Remote Settings mocks. This test case happens to wait for the full duration of the timeout as part of the success path of the test case.
I've reverted the timeout change, and everything should hopefully be fine now.
I would one day like to either fully separate this code, or unify it in a way that ml doesn't rely on Translations under the hood, so that its more clear where the downstream consumers are.
|
|
Assignee | |
Comment 7•3 months ago
|
||
Restoring the original timeout seems to have fixed the issue:
- https://hg.mozilla.org/try/rev/f90e8c8356a1b6f859b28cf430158700cbf43901
- https://treeherder.mozilla.org/jobs?repo=try&revision=c4b57d3456613bf4d05a01e04ce95a3679a2c8db
Attempting re-landing.
|
||
Comment 10•3 months ago
|
||
Authored by https://github.com/nordzilla
https://github.com/mozilla/enterprise-firefox/commit/3aa222d1ad143f197b5475fbf1a685b356182be8
[enterprise-main] Bug 2019120 - Display about:translations Feature Blocked Info Message r=sfoster,fluent-reviewers,bolsson
Authored by Sandor Molnar
https://github.com/mozilla/enterprise-firefox/commit/8f5e1b754a8b52fdc7a5a2bfd38172e5091051f6
[enterprise-main] Revert "Bug 2019120 - Display about:translations Feature Blocked Info Message r=sfoster,fluent-reviewers,bolsson" for causing bc failures @ browser_MLSuggest_integration.js
Authored by https://github.com/nordzilla
https://github.com/mozilla/enterprise-firefox/commit/5acbdbc4184ca08aef961a4c008e83569c8e68e9
[enterprise-main] Bug 2019120 - Display about:translations Feature Blocked Info Message r=sfoster,fluent-reviewers,bolsson
|
||
Updated•2 months ago
|
Description
•