2019169 - Update the search mode switcher menu for Nova

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Drew Willcoxon :adw]

It looks like the Nova spec calls for a non-native menu for the search mode switcher. I think we're using a native menu right now, at least that's what I see on Mac. We should check with the chrome team to see if there's some common Nova menu component, styling, etc.

See Figma for details.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 2019169: Update the search mode switcher popup style

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d63f4201dd54
https://hg.mozilla.org/integration/autoland/rev/96051e10037f
Update the search mode switcher popup style r=desktop-theme-reviewers,adw,dao,fluent-reviewers,bolsson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/08d79be3f2dd
https://hg.mozilla.org/integration/autoland/rev/1b0581317c8e
Revert "Bug 2019169: Update the search mode switcher popup style r=desktop-theme-reviewers,adw,dao,fluent-reviewers,bolsson" for causing bc failures.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Hi! Was this patch backed out??

Comment 5

[agoloman]

Yes, sorry I forgot to leave the backout message.
Backed out for causing bc failures.

• Backout link
• Push with failures
• Failure Log
  Failure message:

test_content_document_selector - A promise chain failed to handle a rejection: [fluent] Missing message in locale en-US: urlbar-searchmode-popup-description-menucaption - stack: (No stack available.)

Comment 6

[Daisuke Akatsuka (:daisuke)]

Okay, thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eb19f9acd4c7
https://hg.mozilla.org/integration/autoland/rev/74a5b0954001
Update the search mode switcher popup style r=desktop-theme-reviewers,adw,dao,fluent-reviewers,bolsson

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c9dbb121454a
https://hg.mozilla.org/integration/autoland/rev/f325207abdc5
Revert "Bug 2019169: Update the search mode switcher popup style r=desktop-theme-reviewers,adw,dao,fluent-reviewers,bolsson" for causing bc failures @browser_searchModeSwitcher_opensearchInstall.js.

Comment 9

[agoloman]

Backed out for causing bc failures @browser_searchModeSwitcher_opensearchInstall.js.

• Backout link
• Push with failures
• Failure Log
• Failure Log @test_XHR_timeout.html

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9d997e1ee792
https://hg.mozilla.org/integration/autoland/rev/f5dba54e6865
Update the search mode switcher popup style r=desktop-theme-reviewers,adw,dao,fluent-reviewers,bolsson

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f5dba54e6865