2019177 - Custom Tabs' system tray & navbar are purple (private-browsing themed), if Firefox Nightly has a private tab in the foreground

Status: RESOLVED WORKSFORME

(Firefox for Android :: Tabs, defect)

Description

[Daniel Holbert [:dholbert]]

This is very similar to bug 2012254, but in a slightly different component and with a more-recent regression range.

Steps to reproduce

1. Ensure that your device is using a "light" theme in System Settings; and in Firefox Nightly's Settings|Customize section, choose to follow the device theme.
2. Set Firefox Nightly as your default browser.
3. Open a private tab in Firefox Nightly (e.g. just tap the mask icon on the Firefox homepage)
4. Launch another app, e.g. Gmail, and tap a link to spawn a custom tab.
5. Tap the 3-dot=menu in the custom tab.

Expected behavior

The system tray at the top of the screen and the nav-bar at the bottom of the screen should match the color of the Firefox custom-tab toolbar (as they do if you skip step 3 of the STR).

Actual behavior

The system tray at the top of the screen and the nav-bar at the bottom of the screen are purple, i.e. private-browsing-themed.

Device information

• Firefox version: 149.0a1 Nightly, 150.0a1 Nightly
• Android device model: Pixel 6a
• Android OS version: 16

Any additional information?

Regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7df40d9149a3d5135ccdcf8602299a76bf7f0081&tochange=06d48ece4edf6a0c4499cc65f627bbb5ad9820eb

In there, I'm pretty sure this would be from Bug 2006631, which changed the way that we query for the "are we in private browsing" state.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of expected rendering

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug, with 3-dot-menu open (gray menu extending upwards from purple navbar)

This bug is particularly noticeable when you open the 3-dot menu -- as of today's Nightly (thanks to bug 2012254), the menu is properly themed (dark gray), but it's extending upwards from a purple bottom-navbar which looks broken.

Here's a screenshot of that.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: screenshot of expected rendering, with 3-dot-menu open (gray menu extending upwards from gray navbar)

Comment 5

[Daniel Holbert [:dholbert]]

Andrey, maybe you could take a look at this regression from bug 2006631?

Comment 6

[Andrey Zinovyev]

Attachment: Bug 2019177 - Use system theme for custom tab UI instead of global browsing mode.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4292a100737c
https://hg.mozilla.org/integration/autoland/rev/84c01f28f193
Use system theme for custom tab UI instead of global browsing mode. r=android-reviewers,skhan

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/84c01f28f193

Comment 9

[Daniel Holbert [:dholbert]]

Thanks for the fix!

I noticed one other bit of UI that's got the same issue -- the "Copy" context-menu that appears if you long-press the custom tab's top-toolbar. That's got a purple background right now, if Firefox Nightly happens to have a private tab as the foreground tab.

Not sure if that'll be fixed by the patch that landed today -- I'll retest that in tomorrow's Nightly and file a bug if that part is still broken.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:azinovyev, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox149 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Users see wrong UI.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps to reproduce

1. Ensure that your device is using a "light" theme in System Settings; and in Firefox Nightly's Settings|Customize section, choose to follow the device theme.
2. Set Firefox Nightly as your default browser.
3. Open a private tab in Firefox Nightly (e.g. just tap the mask icon on the Firefox homepage)
4. Launch another app, e.g. Gmail, and tap a link to spawn a custom tab.
5. Tap the 3-dot=menu in the custom tab.

Expected behavior

The system tray at the top of the screen and the nav-bar at the bottom of the screen should match the color of the Firefox custom-tab toolbar (as they do if you skip step 3 of the STR).

Actual behavior

The system tray at the top of the screen and the nav-bar at the bottom of the screen are purple, i.e. private-browsing-themed.

• Risk associated with taking this patch: low
• Explanation of risk level: UI change
• String changes made/needed: No
• Is Android affected?: yes

Comment 12

[Andrey Zinovyev]

Attachment: Bug 2019177 - Use system theme for custom tab UI instead of global browsing mode.

Original Revision: https://phabricator.services.mozilla.com/D284862

Comment 13

[Daniel Holbert [:dholbert]]

(The related issue that I mentioned in comment 9 persists in latest Nightly, so I'll file a new bug on that.)

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/5282ccddd132
https://hg.mozilla.org/releases/mozilla-beta/rev/b59b73a7c97d

Comment 15

[Lorand Janos]

Attachment: Custom toolbar.jpg

Verified as fixed on the latest Beta 149.0b3 and on the latest Nightly 150.0a1 builds.

The system tray at the top of the screen and the nav-bar at the bottom of the screen do match the color of the Firefox custom-tab toolbar.

Devices used:

• Motorola Nexus 6 (Android 8);
• Google Pixel 9 Pro XL (Android 16);
• Samsung Galaxy S25 Ultra (Android 16).

Marking the ticket as verified on 149 and 150.

Comment 16

[Jonathan Almeida [:jonalmeida]]

Attachment: Revert "Bug 2019177 - Use system theme for custom tab UI instead of global browsing mode. r=azinovyev,skhan"

This reverts commit 4292a100737cd482804813491bc2626870f39c03.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1d6037451f7d
https://hg.mozilla.org/integration/autoland/rev/4a24c2464a52
Revert "Bug 2019177 - Use system theme for custom tab UI instead of global browsing mode. r=azinovyev,android-reviewers"

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Seems like this bug should be reopened if we're reverting the change. Is this being backed out from Beta also, Jon?

Comment 20

[Serban Stanca [:SerbanS]]

Backout was merged in central: https://hg-edge.mozilla.org/mozilla-central/rev/4a24c2464a529217c0fbf182843e2731f8d76136

Comment 21

[Jonathan Almeida [:jonalmeida]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #19)

Seems like this bug should be reopened if we're reverting the change. Is this being backed out from Beta also, Jon?

Yeah, the back-out will be uplifted to beta on Monday if the weekend backout is stable. We can then close the regressions with bug 2009823 re-opened.

Keeping NI as a to-do reminder.

Comment 22

[Jonathan Almeida [:jonalmeida]]

Attachment: Revert "Bug 2019177 - Use system theme for custom tab UI instead of global browsing mode. "

This reverts commit 4292a100737cd482804813491bc2626870f39c03.

Original Revision: https://phabricator.services.mozilla.com/D286147

Comment 23

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/0c8aece9d4b9
https://hg.mozilla.org/releases/mozilla-beta/rev/eff16289b8de

Comment 24

[Pascal Chevrel (relman team) -> :pascalc]

Reverted in beta and main.

Comment 25

[Jonathan Almeida [:jonalmeida]]

Attachment: Revert "Bug 2019177 - Use system theme for custom tab UI instead of global browsing mode. "

This reverts commit 4292a100737cd482804813491bc2626870f39c03.

Comment 26

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/7ac4b53674f5
https://hg.mozilla.org/releases/mozilla-beta/rev/edf74152c2dc

Comment 27

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/15d9e78f928b
https://hg.mozilla.org/releases/mozilla-beta/rev/e5633e9d6021

Comment 28

[Jonathan Almeida [:jonalmeida]]

(In reply to Jonathan Almeida [:jonalmeida] from comment #21)

Keeping NI as a to-do reminder.

It is done.

Comment 29

[Jonathan Almeida [:jonalmeida]]

Updating as per comment 28.

Comment 30

[Jonathan Almeida [:jonalmeida]]

Closing since we have reverted the offending patches.