2019235 - Move tab to Start/ End options are enabled and not working, even if the Split View tab is already at start/en,d and the other view is focused

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser: Split View, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 06-10 July, please ni? :mboldan]]

Attachment: split_1.gif

Found in

• 149.0b1

Affected versions

• 150.0a1 (2025-02-24)
• 149.0b1

Tested platforms

• Affected platforms: macOS 26, Ubuntu 24, Windows 11
• Unaffected platforms: none

Steps to reproduce

1. Move a Split View to end on the tab bar.
2. R-Click on the left view and select the Move tab option.

Expected result

• The move tab to End is greyed out.

Actual result

• The move tab to end is available and does nothing

Regression range

• not a regression.

Additional notes

• Attached a screen recording.

Comment 1

[Noble Chinonso]

i will like to work on this

Comment 2

[japandi]

assign me please

Comment 3

[Noble Chinonso]

I've reproduced this on my local build. On my build the option appears greyed out but still shows a hover effect and is not fully disabled. I'm ready to start investigating the fix.

Comment 4

[Noble Chinonso]

Attachment: Bug 2019235 - Disable Move to Start/End for split view tabs based on tab position

Comment 5

[Noble Chinonso]

Patch is up for review: https://phabricator.services.mozilla.com/D290115.

This fix makes sure the 'Move' options in the context menu respect the boundaries of the entire Split View tab. This stops the 'Move to Start/End' from staying active when the split is already at the edge. Tested with pinned tabs too!

Comment 6

[Noble Chinonso]

Attachment: Bug 2019235 - Add test for Split View context menu boundary conditions

Comment 7

[Noble Chinonso]

Attachment: WIP: Bug 2019235 - Disable Move to Start/End for split view tabs and add tests

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7ef06b5561d3
https://hg.mozilla.org/integration/autoland/rev/d619f8fbe973
Disable Move to Start/End for split view tabs based on tab position r=tabbrowser-reviewers,kcochrane

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d619f8fbe973

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nobleugwuja, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox150 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Noble Chinonso]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #10)

The patch landed in nightly and beta is affected.
:nobleugwuja, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox150 to wontfix.

For more information, please visit BugBot documentation.

I'm not sure if this requires an uplift. But I'd appreciate guidance on the right call here.

Comment 12

[Kelly Cochrane [:kcochrane]]

Checking with :sclements on if we want to uplift this to beta or not

Comment 13

[Sarah Clements [:sclements]]

We're not going to uplift this since its a minor issue with low severity.

Comment 14

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 06-10 July, please ni? :mboldan]]

Verified with Firefox 151.0b10 on Windows 11, macOS 15 and Ubuntu 24 that the Move tab to End/Start options are correctly disabled if the Split View is located at the start of end of the tabstrip