Closed
Bug 2019256
Opened 1 month ago
Closed 1 month ago
Make the SearchInFileBar a shared Component
Categories
(DevTools :: Framework, task)
DevTools
Framework
Tracking
(firefox150 fixed)
RESOLVED
FIXED
150 Branch
| Tracking | Status | |
|---|---|---|
| firefox150 | --- | fixed |
People
(Reporter: bomsy, Assigned: cvl123abc)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We unify the file search behaviour across the devtools panel. To accomplish this, we need to decouple and move the SearchInFileBar Component (https://searchfox.org/firefox-main/rev/1f43fe5ffadde0b6898daf607cabb3335dd75d6f/devtools/client/debugger/src/components/Editor/SearchInFileBar.js) from debugger panel and move it to the devtools/client/shared/components/ folder.
| Reporter | ||
Updated•1 month ago
|
Component: Netmonitor → Framework
| Assignee | ||
Comment 1•1 month ago
|
||
Move SearchInFileBar into devtools/client/shared/components as FileSearchBar, and
add a Debugger-side FileSearch wrapper that wires editor/search helpers and
selectors/actions without debugger-specific imports in the shared component.
Updated•1 month ago
|
Assignee: nobody → cvl123abc
Status: NEW → ASSIGNED
Pushed by hmanilla@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/c8390b5d99a9
https://hg.mozilla.org/integration/autoland/rev/8d16deffc3cd
Move SearchInFileBar to shared and add Debugger wrapper. r=devtools-reviewers,bomsy
Comment 3•1 month ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox150:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
| Reporter | ||
Updated•1 month ago
|
Summary: Make the SearchInput a shared Component → Make the SearchInFileBar a shared Component
Updated•14 days ago
|
QA Whiteboard: [qa-triage-done-c151/b150]
You need to log in
before you can comment on or make changes to this bug.
Description
•