2019461 - Allow remote fingerprint to change when performing an ICE restart, and fix protocol/handover-datachannel.html and protocol/handover.html

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, task, P2)

Description

[Byron Campen [:bwc]]

These tests are simply wrong, and if anything should be inverted.

Comment 1

[Byron Campen [:bwc]]

Ok, it looks like this is what we need to be implementing here:

https://datatracker.ietf.org/doc/html/rfc9429#section-5.11-3.2

That does not require tls-id. Now, the test-case still needs some work. Changing fingerprint/tls-id requires an ICE restart, which the test is not doing:

https://datatracker.ietf.org/doc/html/rfc8842#section-6-3

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 2019461: Test cases for DTLS restart. r?mjf

Fixes bug in existing test-cases that attempt a DTLS restart without an
ICE restart. Adds some more demanding tests too.

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 2019461: Create MediaPacket before firing signals. r?mjf

Subsequent patch has to do fanout to multiple TransportFlows before
creating the MediaPacket, so we move that MediaPacket creation earlier
to avoid needing to do it more than once.

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 2019461: Implement DTLS restart. r?mjf

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6c497ba28906
https://hg.mozilla.org/integration/autoland/rev/1fe234bbc453
Test cases for DTLS restart. r=mjf
https://github.com/mozilla-firefox/firefox/commit/95a3fcbb0ace
https://hg.mozilla.org/integration/autoland/rev/ba5c1f0ac05a
Create MediaPacket before firing signals. r=mjf
https://github.com/mozilla-firefox/firefox/commit/5c83911a8081
https://hg.mozilla.org/integration/autoland/rev/a1a92359d6fb
Implement DTLS restart. r=mjf

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/62755 for changes under testing/web-platform/tests

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1fe234bbc453
https://hg.mozilla.org/mozilla-central/rev/ba5c1f0ac05a
https://hg.mozilla.org/mozilla-central/rev/a1a92359d6fb

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1fe234bbc453
https://hg.mozilla.org/mozilla-central/rev/ba5c1f0ac05a
https://hg.mozilla.org/mozilla-central/rev/a1a92359d6fb

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging