2019550 - Cannot collapse/expand the full document outline of a PDF anymore

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Rob Wu [:robwu]]

Until Firefox 147, it used to be possible to expand or collapse all sections of a PDF document outline by double-clicking on the "Show Document Outline" button (with tooltip Show Document Outline (double-click to expand/collapse all items)).

I originally added the functionality and explanation in https://github.com/mozilla/pdf.js/pull/6242.

STR:

1. Open https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf
2. Look for the "Document outline" button
3. Try to double-click it.

Expected:

• Am able to double-click to collapse/expand all outlines.

Actual:

• Not possible from Firefox 148.

This appears to be a regression from https://github.com/mozilla/pdf.js/pull/20495
The underlying logic is still in the code, but it appears that the functionality is unavailable because the "Document outline" button has now moved into a submenu (opened via the "Views" button).

If I force the menu to be shown (and not hide on click), with document.getElementById("viewsManagerSelectorOptions").style.visibility = "visible"
then I can double-click on the "Document outline" button.

Comment 1

[Rob Wu [:robwu]]

Brought to my attention via this report: https://connect.mozilla.org/t5/discussions/pdf-viewer-quot-find-current-outline-item-quot-double-clicking/td-p/118725

Looks like an issue was also opened just now at https://github.com/mozilla/pdf.js/issues/20739

Comment 2

[Rob Wu [:robwu]]

"Regressed by" cannot link to a Github URL, so I am adding the regressor as See also: https://github.com/mozilla/pdf.js/pull/20495

Calixte, as the author of the regression, could you take a look? Perhaps we should add a toggle all outlines button if a PDF has multiple outlines?

Comment 3

[Rob Wu [:robwu]]

Note that the original flow was documented at https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#outline-sidebar :

• To expand/collapse all items under the selected item, press Shift while clicking on the triangle.
• Double-click on the "Show document outline" button (Show document outline) to expand/collapse all outline items.

Right now, when I Shift-click in the outline, the whole outline collapses, not just the section underneath. That is a bug... It should only collapse the outlines under the section.

And to deal with the regression reported here, an option could be to introduce an artificial top-level triangle, extra buttons, or something else.

Comment 4

[Calixte Denizet (:calixte)]

I wasn't aware of this feature so we didn't take into account when designing the new sidebar.
:Ryan, what do you think we can do ?

Comment 5

[Calixte Denizet (:calixte)]

So for now we don't plan to fix the issue but we keep it in mind.

Comment 6

[Ryan Casey]

UX has taken note and will keep in mind for future updates.

Comment 7

[Calixte Denizet (:calixte)]

For now, let's "fix" this bug in adding a new hidden feature: double-clicking on the header part of the sidebar will collapse/expand all the outlines or hide/show all the layers.
And we'll figure out later a better way to expose this feature or not to everybody and not keep it confidential.

Comment 8

[BMO Github Automation]

Attachment: [mozilla/pdf.js] Allow to collapse/expand all the outlines in double clicking somewhere on the header bar (bug 2019550) (#20852)