20196 - Add Xlib support for --display

Status: VERIFIED FIXED

(Core Graveyard :: Cmd-line Features, enhancement, P3)

Description

[Gabriel Klein]

Doesn't reconize option "-display" to redirect the display in the command line.

Comment 1

[Eli Goldberg]

Reassigning all of leger's unscreened Browser-General bugs to [e-mail]
for pre-screening and triage.

Comment 2

[John Morrison]

This bug needs review by a Solaris X-head. mcafee : what the story for
option "-display"?

Comment 3

[Chris McAfee]

Yes, we should do this.  m15

Comment 4

[don]

Move to M16 for now ...

Comment 5

[Blake Ross]

*spam* changing qa contact from [e-mail] to me ([e-mail]) 
on 121 open or resolved (but not verified) bugs.  sorry for the spam everybody, 
but most of these bugs would just remain dormant and not checked by QA 
otherwise.  I'm not sure how so many bugs have nobody as their QA contact, but 
I suspect this is the fault of some sort of bugzilla corruption that happened 
at some point (most of these bugs are in the 20000-26000 range, and I don't see 
where in the activity log that QA contact explicitly changed to 
[e-mail])

Anyways, sorry again for spam.  If you really get annoyed, I'm usually 
available in #mozilla on IRC for torture.

Comment 6

[timeless]

McAfee, would this also work for Linux or other X11 clients?

Arg, why was this silently futured?

Adding keywords and asking that this be considered for implementation by 
nsbeta3 instead of in the too distant future.

Comment 7

[johng]

nav triage team:
nsbeta3-, we could ship without this.  Helpwanted incase someone wants to check
in a fix from mozilla.

Comment 8

[sairuh (rarely reading bugmail)]

moving this over to keybd nav. blake, feel free to take back if you really want
this (but do add me to the cc list).

Comment 9

[Chris McAfee]

this is a commandline option, not sure why keyboard nav
was chosen here.  wrong bug?

Comment 10

[Marcia Knous [:marcia]]

Netscape Nav triage team: this is not a Netscape beta stopper.

Comment 11

[Matthew Tuck [:CodeMachine]]

Bug #20573 covers all standard X command line options.

Comment 12

[Paul Chen]

Marking nsbeta1- bugs as future to get off the radar

Comment 13

[Raghu Sakleshpur]

This occurs on linux platform when tested with mozilla nightly build:
2001041704. Updating the OS to linux.

Comment 14

[timeless]

Attachment: xlib support for --display and --sync

Comment 15

[timeless]

this patch works and gives xlib parity with the other x11 toolkits.

Blizzard: it's a small patch, just copying a few lines around, would you sr= 
this?

Setting milestone pessimisticly.

Comment 16

[Boris Zbarsky [:bzbarsky]]

r=[e-mail].

Comment 17

[Christopher Blizzard (:blizzard)]

While you are at it you should add -display support since many apps support it.
 Anyway, other than that, r=blizzard

Comment 18

[timeless]

Attachment: handle -display and use macros for readability

Comment 19

[timeless]

Attachment: whoops, corrected syntax

Comment 20

[Boris Zbarsky [:bzbarsky]]

Looks good.  Works when tested too.  :)

r=[e-mail]

Comment 21

[Asa Dotzler [:asa]]

tree closed to all but the most critical checkins. this can wait till 0.9.1. 
clearing status whiteboard. 

Comment 22

[timeless]

fix checked in. requesting pardon in a few days for 0.9 branch.  This improves 
xlib's support by adding -display/--display and should have no risk.

Comment 23

[Frank Belew]

-display foo and --display foo work for me
I would like '--display=foo' to work though
Still verifying as fixed

Mozilla/5.0 (X11; U; Linux 2.4.2-XFS i686; en-US; rv:0.9+) Gecko/20010522

$HOME/mozconfig:
ac_add_options --enable-toolkit=xlib
ac_add_options --without-gtk
ac_add_options --with-xlib
ac_add_options --disable-gtktest
ac_add_options --disable-gdk_pixbuftest
ac_add_options --disable-glibtest
ac_add_options --with-pthreads
ac_add_options --disable-mailnews
ac_add_options --disable-short-wchar
ac_add_options --enable-optimize="-mpentiumpro -O2"
ac_add_options --disable-debug
#ac_add_options --enable-jprof
ac_add_options --enable-chrome-format=jar
ac_add_options --disable-pedantic
#ac_add_options --enable-eazel-profiler
#ac_add_options --with-profile-modules=layout,gfx,widget,view
ac_add_options --enable-xterm-updates
ac_add_options --disable-ldap
ac_add_options --enable-nspr-autoconf