2019623 - Add columns to moz_origins and preferences for temporary autofill blocking

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[James Teow [:jteow]]

When the user backspaces or dismisses the autofill suggestion, we add to this temporary blocklist, for a while (let’s start with 7 days for dismiss, 2 days for backspace) the url won’t be suggested. This removes the immediate annoyance of getting a wrong result repeatedly, while at the same time reduces the risk of accidental dismissals blocklisting the url forever. During the timeframe we assume the user can train Firefox to pick a better result.

We can add a block_until_ms and block_pages_until_ms timestamp column to moz_origins. The former is used on the origin, the latter is used on all subpages.

Set a blocklist expiration date in it, compare with current time when querying.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 2019623 - Part 1: Add block_until_ms and block_pages_until_ms to moz_origins - r?#places-reviewers!

Comment 2

[James Teow [:jteow]]

Attachment: Bug 2019623 - Part 2: Add block list duration preferences and Nimbus variables - r?#urlbar-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3809552c7889
https://hg.mozilla.org/integration/autoland/rev/7fa97f8e43d3
Part 1: Add block_until_ms and block_pages_until_ms to moz_origins - r=places-reviewers,daisuke
https://github.com/mozilla-firefox/firefox/commit/ec0c58ca5808
https://hg.mozilla.org/integration/autoland/rev/ab88542bc350
Part 2: Add block list duration preferences and Nimbus variables - r=urlbar-reviewers,daisuke

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7fa97f8e43d3
https://hg.mozilla.org/mozilla-central/rev/ab88542bc350