Closed
Bug 201964
Opened 22 years ago
Closed 22 years ago
Widget state manager fails to set empty menulist values
Categories
(SeaMonkey :: Preferences, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: neil, Assigned: bugs)
References
()
Details
Attachments
(1 file)
|
732 bytes,
patch
|
shliang
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
This code is wrong:
element.selectedItem = element.getElementsByAttribute( "value",
aDataObject.value )[0];
The code in menulist.xml does it correctly. Rather than duplicating that code I
suggest using it:
element.value = aDataObject.value;
|
Reporter | |
Comment 1•22 years ago
|
||
|
|
Reporter | |
Updated•22 years ago
|
Attachment #120437 -
Flags: superreview?(jaggernaut)
Attachment #120437 -
Flags: review?(shliang)
Attachment #120437 -
Flags: review?(shliang) → review+
|
||
Comment 2•22 years ago
|
||
Comment on attachment 120437 [details] [diff] [review]
As advertised
sr=jag
Attachment #120437 -
Flags: superreview?(jaggernaut) → superreview+
checked this in, thanks neil
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•