2019661 - Prompts shouldn't be automatically closed when only WebDriver classic is used

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Reported at https://github.com/mozilla/geckodriver/issues/2241

Launch Firefox with Geckodriver, open a JS console and try running alert("hi"). I expect to see an alert, but nothing seems to happen instead. (confirm() appears similarly broken; I see that it always instantly returns false.)

Sasha, can you please take a look? Thanks.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:Sasha, since you are the author of the regressor, bug 1905086, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 2019661 - Initialize "UserPromptHandlerManager" only when "bidi" flag is set on the session.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d6915cc5e1be
https://hg.mozilla.org/integration/autoland/rev/e41605b23348
Initialize "UserPromptHandlerManager" only when "bidi" flag is set on the session. r=whimboo

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e41605b23348

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Sasha, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox149 to wontfix.

For more information, please visit BugBot documentation.