201983 - nsImageFrame::TranslateEventCoords assumes aResult is initialized

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[David Bradley]

When it's called from nsImageFrame::GetContextForEvent and other places, the
point passed in isn't initialized. nsBoxFrame seems to suffer the same problem.
The default constructor of nsPoint doesn't initialize it's members.

Comment 1

[David Bradley]

Slight correction, it's aPoint, not aResult that isn't initialized.

Comment 2

[Christopher Hoess (gone)]

->Misc Code

Comment 3

[Boris Zbarsky [:bzbarsky]]

See also bug 10606

Comment 4

[David Bradley]

It's hard to say, since I don't have a lot of history to go on here. But it's
possible that the original author(s) may have done this on purpose for nsPoint.
In the case of events, I'm not sure the point member is always valid. Thus
default initializing it to zero for events that don't have coordinates is a
small waste of time. I have no idea if the time involved to initialize it would
impact anything noticeably. I could imagine that constructing an array of points
in other places, it might be noticeable.

Comment 5

[Boris Zbarsky [:bzbarsky]]

This seems to be wfm now: all callers pass in a reasonable aPoint.