2019940 - Crash in [@ webrender::render_task::render_task_sanity_check]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Nicolas Silva [:nical]]

Followup from bug 2011700 with a similar yet different cause (the task is too big instead of being zero-sized).

Just experienced this on a redash dashboard I clicked 'edit' on.

Crash report: https://crash-stats.mozilla.org/report/index/82dc85f2-17c1-4564-a684-393950260226

Stack:

7 	XUL 	webrender::render_task::render_task_sanity_check 	gfx/wr/webrender/src/render_task.rs:47 	inlined
7 	XUL 	webrender::render_task::RenderTask::new 	gfx/wr/webrender/src/render_task.rs:974 	inlined
7 	XUL 	webrender::render_task::RenderTask::new_dynamic 	gfx/wr/webrender/src/render_task.rs:994 	cfi
8 	XUL 	webrender::quad::add_render_task_with_mask::{{closure}} 	gfx/wr/webrender/src/quad.rs:1442 	cfi
9 	XUL 	webrender::render_task_cache::RenderTaskCache::request_render_task 	gfx/wr/webrender/src/render_task_cache.rs:244 	inlined
9 	XUL 	webrender::resource_cache::ResourceCache::request_render_task 	gfx/wr/webrender/src/resource_cache.rs:642 	cfi
10 	XUL 	webrender::quad::add_render_task_with_mask 	gfx/wr/webrender/src/quad.rs:1434 	inlined
10 	XUL 	webrender::quad::prepare_indirect_pattern 	gfx/wr/webrender/src/quad.rs:826 	cfi
11 	XUL 	webrender::quad::prepare_repeatable_quad 	gfx/wr/webrender/src/quad.rs:282 	cfi
12 	XUL 	webrender::prepare::prepare_interned_prim_for_render 	gfx/wr/webrender/src/prepare.rs:0 	cfi

Comment 1

[BugBot [:suhaib / :marco]]

The bug is linked to a topcrash signature, which matches the following criteria:

• Top 10 desktop browser crashes on nightly
• Top 10 AArch64 and ARM crashes on nightly

:nical, could you consider increasing the severity of this top-crash bug?

For more information, please visit BugBot documentation.

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 2019940 - Down-scale indrect tasks if they are too large. r=gw

This addresses two issues:

• The repeatable pattern code was not down-scaling render tasks that are too wide or tall. We don't take this code path if the task is more than 1k*1k but we may if it is small on one axis and large on the other. This patch ensures that the down-scaling happens in this situation.
• The border-image repetition code was down-scaling at the transform level but failed to update the surface rect that the task size is built from, so it was updated to do that.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/56aa4f231e11
https://hg.mozilla.org/integration/autoland/rev/966f9184306a
Down-scale indrect tasks if they are too large. r=gw

Comment 4

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/966f9184306a