2019950 - fetch keepalive requests ignore offline network conditions

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Holger Benl [:hbenl]]

This Playwright test fails because a fetch with keepalive: true succeeds in offline mode.
I was able to reproduce the issue with this test:

@pytest_asyncio.fixture
async def get_can_fetch2(bidi_session, url):
    async def get_can_fetch2(context):
        try:
            await bidi_session.script.call_function(
                function_declaration="(url)=>fetch(url, { cache: 'no-store', keepalive: true })",
                arguments=[{
                    "type": "string",
                    "value": url("/common/dummy.json")
                }],
                target=ContextTarget(context["context"]),
                await_promise=True,
            )
            return True
        except ScriptEvaluateResultException:
            return False

    return get_can_fetch2

async def test_fetch_keepalive(bidi_session, top_context, url, get_can_fetch2):
    # Navigate away from about:blank to allow fetch requests.
    await bidi_session.browsing_context.navigate(
        context=top_context["context"],
        url=url("/common/blank.html"),
        wait="complete")

    assert await get_can_fetch2(top_context)
    await bidi_session.emulation.set_network_conditions(
        network_conditions=OFFLINE_NETWORK_CONDITIONS,
        contexts=[top_context["context"]])
    assert not await get_can_fetch2(top_context)
    await bidi_session.emulation.set_network_conditions(
        network_conditions=None,
        contexts=[top_context["context"]])
    assert await get_can_fetch2(top_context)

The test passes when I remove the keepalive: true option.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 2019950 - [bidi] Clarify role of hasGlobalOverride in emulation module

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 2019950 - [bidi] Cancel keepAlive requests from beforeRequestSent handler

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 2019950 - [wdspec] Add test for keepalive fetch requests with offline network conditions

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 2019950 - [wdspec] Add test for setExtraHeaders after unsubscribing from network events

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/de6f3e903c73
https://hg.mozilla.org/integration/autoland/rev/4158ed598f10
[bidi] Clarify role of hasGlobalOverride in emulation module r=Sasha
https://github.com/mozilla-firefox/firefox/commit/587c1699ac24
https://hg.mozilla.org/integration/autoland/rev/b6e0147c8155
[bidi] Cancel keepAlive requests from beforeRequestSent handler r=Sasha
https://github.com/mozilla-firefox/firefox/commit/d8699183f570
https://hg.mozilla.org/integration/autoland/rev/e303414a3032
[wdspec] Add test for keepalive fetch requests with offline network conditions r=Sasha
https://github.com/mozilla-firefox/firefox/commit/49c86ede9628
https://hg.mozilla.org/integration/autoland/rev/65f2b0a20297
[wdspec] Add test for setExtraHeaders after unsubscribing from network events r=Sasha

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58479 for changes under testing/web-platform/tests

Comment 7

[rperta]

https://hg.mozilla.org/mozilla-central/rev/4158ed598f10
https://hg.mozilla.org/mozilla-central/rev/b6e0147c8155
https://hg.mozilla.org/mozilla-central/rev/e303414a3032
https://hg.mozilla.org/mozilla-central/rev/65f2b0a20297

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Julian Descottes [:jdescottes]]

Removing relnote here, since this was something missing in the initial implementation for offline mode, which landed in the same release.