2019988 - Update the panel-list variant of moz-select to use role="combobox"

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Hanna Jones [:hjones]]

Based on some of the issues flagged in bug 2019492 it looks like we need to make improvements to the accessibility semantics of the panel-list variant of moz-select to have it announce properly to screen readers. According to :akulyk updating the panelTargetTemplate to have the following attributes causes this select to announce in the same way as the native select:

role="combobox"
aria-label=${ifDefined(this.ariaLabel)}
aria-labelledby="label"

We should double check if we need both the aria-label and aria-labelledby, since according to MDN aria-labelledby will take precedence over all other methods of providing an accessible name.

Comment 1

[akulyk]

Attachment: Bug 2019988 - Update the panel-list variant of moz-select to use role="combobox" r=#recomp-reviewers,hjones

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c30a86fae120
https://hg.mozilla.org/integration/autoland/rev/0b7cd0cf7ce9
Update the panel-list variant of moz-select to use role="combobox" r=hjones

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f1370b7bcba0
https://hg.mozilla.org/integration/autoland/rev/0d7fd62a3b05
Revert "Bug 2019988 - Update the panel-list variant of moz-select to use role="combobox" r=hjones" for causing bc failures on browser_searchDefaultEngine.js.

Comment 4

[Iulian Moraru]

Revert for causing bc failures on browser_searchDefaultEngine.js.

• Push with failures

• Failure log

• Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9399fd35dc6e
https://hg.mozilla.org/integration/autoland/rev/9aeaa63f2696
Update the panel-list variant of moz-select to use role="combobox" r=hjones

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9aeaa63f2696