2020003 - Add support for weak map edges to nsICycleCollectorListener.idl

Status: RESOLVED FIXED

(Core :: Cycle Collector, task)

Description

[Andrew McCreight [:mccr8]]

Eons ago I added support for weak maps to the cycle collector, but I never got around to adding support to nsICycleCollectorListener, which is sort of an experimental interface to get the results of the cycle collection from JS. It hasn't been heavily used, but a few people are exploring using it, so we should implement this.

The implementation of this will have to be in nsCycleCollectorLogger::NoteWeakMapEntry, adding a mWantAfterProcessing case like the other methods.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 2020003 - Add weak map edge support to nsICycleCollectorHandler. r=mccr8

nsICycleCollectorHandler now exposes noteWeakMapEntry, allowing JS
consumers to receive weak map entries from the CC graph. This enables
ShutdownLeakPathFinder and CCAnalyzer to find retention paths that
pass through weak maps.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7b92246a72f7
https://hg.mozilla.org/integration/autoland/rev/a7ce9982d1a9
Add weak map edge support to nsICycleCollectorHandler. r=mccr8,devtools-reviewers,ochameau

Comment 3

[rperta]

https://hg.mozilla.org/mozilla-central/rev/a7ce9982d1a9