2020112 - Firefox strips \t\n\r characters from location.hash, but not from about:blank and data: iframes' hashes

Status: RESOLVED FIXED

(Core :: DOM: Window and Location, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: about_blank_location_hash.html

Firefox strips \t\n\r characters from location.hash, but not from about:blank and data: iframes' hashes.

Chrome and Safari strip \t\n\r characters from location.hash and about:blank and data: iframes' hashes.

Steps to reproduce

1. Load about:blank or data:text/html,test in a tab
2. In the web console, enter location.hash = "foo \t\n\rbar"
3. Check the value of location.hash

Expected value

#foo%20bar like in Chrome and Safari.

Actual value

#foo%20%09%0A%0Dbar

I found this bug while debugging location.hash bug 1733797. I'll add a WPT test case for this issue in that bug, marked as expected to fail and to be fixed in this bug.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 2020112 - Strip ASCII tab and newline from fragment in nsSimpleURI::SetRef. r=#necko-reviewers!

nsSimpleURI::SetRef was not stripping \t, \n, \r characters from the input,
unlike nsStandardURL::SetRef. This caused data: and about:blank URLs to
percent-encode these characters instead of removing them.

Per the URL spec, the hash setter invokes the basic URL parser
(https://url.spec.whatwg.org/#concept-basic-url-parser) which unconditionally
strips all ASCII tab or newline (https://infra.spec.whatwg.org/#ascii-tab-or-newline)
from the input in step 3, before any state-specific processing.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5568c2b3951b
https://hg.mozilla.org/integration/autoland/rev/29c96f6a9fdf
Strip ASCII tab and newline from fragment in nsSimpleURI::SetRef. r=necko-reviewers,valentin

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/29c96f6a9fdf

Comment 4

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:jjaschke, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox149 to wontfix.

For more information, please visit BugBot documentation.