2020227 - Allow snap target elements, which were the targets on an axis, for the other axis when re-snapping

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, defect, P2)

Description

[Hiroyuki Ikezoe (:hiro)]

We disallow such elements on re-snapping, but the spec doesn't mention it clearly. So we can be permissive for such elements.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 2020227 - Prefer the block-axis snap target for both axes when the inline and block re-snap candidate sets are disjoint. r?botond

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3a4fb3b8e8a9
https://hg.mozilla.org/integration/autoland/rev/1523d438049d
Allow the previous snap target elements even if it was for the other axis. r=botond

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/80d8075443c9
https://hg.mozilla.org/integration/autoland/rev/6f204d007023
Revert "Bug 2020227 - Allow the previous snap target elements even if it was for the other axis. r=botond" for causing mochitest related failures at browser_spinner_keynav.js

Comment 4

[rperta]

Backed out for causing mochitest related failures at browser_spinner_keynav.js
Backout link
Push with failures
Failure log(s)

Comment 5

[Hiroyuki Ikezoe (:hiro)]

So the scroll container in the browser test is not horizontally scrollable. But while we are collecting snap targets on resnap, we do collect snap targets even if the scroller is not scrollable on the axis, thus with the check which was dropped in D285438, we did choose an in-appropriate snap target (which is the first element in tree order), that's because in the scroll container all children is positioned at 0 on X axis.

A patch is coming.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 2020227 - Ignore snap points outside of the viewport while collecting last snap target ids for the next re-snapping. r?botond

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1875516aee4a
https://hg.mozilla.org/integration/autoland/rev/8db4ba889629
Ignore snap points outside of the viewport while collecting last snap target ids for the next re-snapping. r=botond
https://github.com/mozilla-firefox/firefox/commit/dbcf56e06414
https://hg.mozilla.org/integration/autoland/rev/cc8522a45c91
Prefer the block-axis snap target for both axes when the inline and block re-snap candidate sets are disjoint. r=botond
https://github.com/mozilla-firefox/firefox/commit/35ce57c04db4
https://hg.mozilla.org/integration/autoland/rev/4bedc9077703
apply code formatting via Lando

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8db4ba889629
https://hg.mozilla.org/mozilla-central/rev/cc8522a45c91
https://hg.mozilla.org/mozilla-central/rev/4bedc9077703

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/59196 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot