2020341 - "Switch to Tab" suggestion is empty

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Masatoshi Kimura [:emk]]

Attachment: screenshot.png

Steps to reproduce:

1. Open any HTML that does not have a title element or that has an empty title element.
2. Open another new tab.
3. Paste the URL of the first tab into the address bar of the second tab. "Switch to Tab" dropdown will appear.

Actual result:
The "Switch to Tab" dropdown is empty. Only the button is shown.

Expected result:
The "Switch to Tab" dropdown should be shown along with the page URL.

Regression range: https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=227d679299ea823f9e5c641d1a944cd28b9ec0e1&tochange=cc596b447fcfafb455eabc2c07e04f4fc2d107ac

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: notitle.html

HTML file with no title for test

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1995227

:daisuke, since you are the author of the regressor, bug 1995227, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Thank you very much for your report, Masatoshi! I will fix this issue.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 2020341: Show url as title for tab switch result if the title is empty

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f1a0e40d1a19
https://hg.mozilla.org/integration/autoland/rev/b4466747ee13
Show url as title for tab switch result if the title is empty r=adw

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/b4466747ee13

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: If the visited page has no title, the suggestion on urlbar shows an empty result.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: The main code changes are a few rows. And this affects only for urlbar results.
• String changes made/needed: None
• Is Android affected?: no

Comment 8

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 2020341: Show url as title for tab switch result if the title is empty

Original Revision: https://phabricator.services.mozilla.com/D285669

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/8323600c69ac
https://hg.mozilla.org/releases/mozilla-beta/rev/d8512c9d4ae6

Comment 10

[Donal Meehan [:dmeehan]]

:daisuke, we could include this Fx148 regression in the planned Fx148 dot release. Could you add a release uplift request?

Comment 11

[Daisuke Akatsuka (:daisuke)]

Okay, thanks!

Comment 12

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: If the visited page has no title, the suggestion on urlbar shows an empty result.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: The main code changes are a few rows. And this affects only for urlbar results.
• String changes made/needed: None
• Is Android affected?: no

Comment 13

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 2020341: Show url as title for tab switch result if the title is empty

Original Revision: https://phabricator.services.mozilla.com/D285669

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/ee5b32ae4995
https://hg.mozilla.org/releases/mozilla-release/rev/083e40f95882

Comment 15

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2026-03-02 Firefox Nightly build on Windows 10.

Verified as fixed on Firefox Nightly 150.0a1, Firefox 149.0b6 and Firefox 148.0.2 on Windows 10, Ubuntu 22, macOS 15.