Artifact build issue causes FELT window to be skipped, launching unauthenticated browser session
Categories
(Enterprise Products :: Firefox, defect)
Tracking
(Not tracked)
People
(Reporter: jporter, Assigned: gerard-majax)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
enterprise-firefox-no-session.png
When building Enterprise Firefox locally for the first time, mach run launches a browser window directly without presenting the FELT authentication window. The session is unauthenticated, the settings menus are absent, no user badge is displayed, and clicking Sign Out kills the mach run process.
I did build both Enterprise Firefox and standard Firefox recently, so suspecting an artifact conflict is to blame.
My mozconfig was the default and only included the line to source build/macosx/mozconfig.enterprise per the README. I chose Firefox for Desktop Artifact Mode during mach bootstrap since it was the suggested default. Built using the enterprise-main branch from the Enterprise Firefox repository.
Attached is a screenshot of what I encountered, and below are logs that were output when attempting to view the settings:
console.warn: "Unable to update user icon in badge without user information"
console.error: "AttributeError: isFxASignedIn"
console.error: (new TypeError("can't access property \"getSignedInUser\", lazy.fxAccounts is undefined", "resource:///modules/asrouter/ASRouterTargeting.sys.mjs", 701))
console.error: (new TypeError("can't access property \"getSignedInUser\", lazy.fxAccounts is undefined", "resource:///modules/asrouter/ASRouterTargeting.sys.mjs", 701))
console.error: (new TypeError("can't access property \"getSignedInUser\", lazy.fxAccounts is undefined", "resource:///modules/asrouter/ASRouterTargeting.sys.mjs", 701))
JavaScript error: resource:///modules/enterprise/ConsoleClient.sys.mjs, line 666: TypeError: can't access property "isFeltBrowser", Services.felt is undefined
JavaScript error: chrome://browser/content/preferences/main.js, line 51: ReferenceError: UpdateUtils is not defined
JavaScript error: chrome://global/content/preferences/Setting.mjs, line 182: PreferenceNotAddedError: Setting "permanentPBEnabledPref" was unable to find Preference "browser.privatebrowsing.autostart". Did you register it with Preferences.add/addAll?
JavaScript error: chrome://global/content/preferences/Setting.mjs, line 182: PreferenceNotAddedError: Setting "privateBrowsingAutoStart" was unable to find Preference "browser.privatebrowsing.autostart". Did you register it with Preferences.add/addAll?
JavaScript error: chrome://browser/content/preferences/sync.js, line 263: ReferenceError: UIState is not defined
|
Assignee | |
Comment 1•6 months ago
|
||
0:03.34 Installing from remote pushhead eb7e47cd8b8f9ddbd976eb86c036c8d820130f29 on mozilla-central
0:03.34 Installing from https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/KWVNKB-sSpuVn_BtRzUieg/artifacts/public/build/target.common.tests.tar.zst
0:03.34 Downloading artifact to local cache: /home/alexandre/Documents/codaz/Mozilla/MiscWork/mozilla-source/.mozbuild/package-frontend/d783b0463fac0b43-target.common.tests.tar.zst
0:03.73 Downloading... 0.0 %
0:04.91 Downloading... 19.7 %
0:05.74 Downloading... 39.4 %
0:06.48 Downloading... 59.1 %
0:07.19 Downloading... 78.8 %
0:07.73 Downloading... 98.5 %
0:07.73 Downloading... 100.0 %
So we find artifact from mozilla-central that is already wrong
|
|
Assignee | |
Comment 2•6 months ago
|
||
Josh, can you confirm that applying this helps?
|
Reporter | |
Comment 3•6 months ago
|
||
Yes, applying that resulted in a working build that properly launches FELT and shows settings properly as well
|
||
Comment 4•6 months ago
|
||
|
|
||
Comment 5•6 months ago
|
||
Authored by Alexandre Lissy
https://github.com/mozilla/enterprise-firefox/commit/f173842062f7012304cfa109fa37f8c439a7fc0f
[enterprise-main] Bug 2020434 - Enterprise: add support for artifact builds
Authored by Alexandre Lissy
https://github.com/mozilla/enterprise-firefox/commit/fbfe32d1d9e57eb3eed18c8509b4f13077ce8c95
[enterprise-main] Bug 2020434 - Enterprise: fix index type and job-name for artifact builds
Authored by https://github.com/lissyx
https://github.com/mozilla/enterprise-firefox/commit/00c29e4d11a3c47ee099286438349f16261954c4
[enterprise-main] Merge pull request #499 from lissyx/enterprise-bug2020434_fix_artifacts_build
Description
•