2020531 - Assertion failure: !input.isDelazifying() (No current support for eager baseline during delazifications.), at js/src/frontend/Stencil.cpp:2820

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Tooru Fujisawa [:arai]]

While testing Stencil Navigation, I hit the following assertion failure

Assertion failure: !input.isDelazifying() (No current support for eager baseline during delazifications.), at js/src/frontend/Stencil.cpp:2820

#01: js::frontend::CompilationStencil::instantiateStencils(JSContext*, js::frontend::CompilationInput&, js::frontend::CompilationStencil const&, js::frontend::CompilationGCOutput&)[XUL +0x7654dbc]
#02: js::frontend::InitialStencilAndDelazifications::instantiateStencils(JSContext*, js::frontend::CompilationInput&, js::frontend::InitialStencilAndDelazifications&, js::frontend::CompilationGCOutput&)[XUL +0x765f42c]
#03: bool InstantiateStencilsImpl<js::frontend::InitialStencilAndDelazifications>(JSContext*, js::frontend::CompilationInput&, js::frontend::InitialStencilAndDelazifications&, js::frontend::CompilationGCOutput&)[XUL +0x75b44e4]
#04: JS::InstantiateGlobalStencil(JSContext*, JS::InstantiateOptions const&, js::frontend::InitialStencilAndDelazifications*, JS::InstantiationStorage*)[XUL +0x7664404]
#05: mozilla::dom::InstantiateStencil(JSContext*, JS::CompileOptions&, js::frontend::InitialStencilAndDelazifications*, JS::MutableHandle<JSScript*>, JS::Handle<JS::Value>, JS::Handle<JSScript*>, mozilla::ErrorResult&, nsTAutoStringN<char, 64ul> const&, JS::In[XUL +0x5c736cc]
#06: mozilla::dom::ScriptLoader::InstantiateClassicScriptFromCachedStencil(JSContext*, JS::CompileOptions&, JS::loader::ScriptLoadRequest*, js::frontend::InitialStencilAndDelazifications*, JS::MutableHandle<JSScript*>, JS::Handle<JS::Value>, JS::Handle<JSScrip[XUL +0x5c73998]
#07: mozilla::dom::ScriptLoader::InstantiateClassicScriptFromAny(JSContext*, JS::CompileOptions&, JS::loader::ScriptLoadRequest*, JS::MutableHandle<JSScript*>, JS::Handle<JS::Value>, JS::Handle<JSScript*>, mozilla::ErrorResult&)[XUL +0x5c73b20]
#08: mozilla::dom::ScriptLoader::EvaluateScript(nsIGlobalObject*, JS::loader::ScriptLoadRequest*)[XUL +0x5c722bc]
#09: mozilla::dom::ScriptLoader::EvaluateScriptElement(JS::loader::ScriptLoadRequest*)[XUL +0x5c712e0]
#10: mozilla::dom::ScriptLoader::ProcessRequest(JS::loader::ScriptLoadRequest*)[XUL +0x5c6d284]
#11: mozilla::dom::ScriptLoader::ProcessPendingRequests(bool)[XUL +0x5c55dc4]
#12: mozilla::detail::RunnableMethodImpl<mozilla::dom::ScriptLoader*, void (mozilla::dom::ScriptLoader::*)(bool), true, (mozilla::RunnableKind)0, bool>::Run()[XUL +0x5c860e8]
#13: mozilla::RunnableTask::Run()[XUL +0x5190a8]
#14: mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&)[XUL +0x5135b4]
#15: mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&)[XUL +0x510c84]
#16: mozilla::TaskController::ProcessPendingMTTask(bool)[XUL +0x511110]
#17: mozilla::detail::RunnableFunction<mozilla::TaskController::TaskController()::$_0>::Run()[XUL +0x523e10]
#18: nsThread::ProcessNextEvent(bool, bool*)[XUL +0x53a734]
#19: NS_ProcessNextEvent(nsIThread*, bool)[XUL +0x540888]
#20: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*)[XUL +0x106581c]
#21: MessageLoop::RunInternal()[XUL +0xfd44a8]
#22: MessageLoop::Run()[XUL +0xfd43a0]
#23: nsBaseAppShell::Run()[XUL +0x5f0dd98]
#24: nsAppShell::Run()[XUL +0x5f8c510]
#25: XRE_RunAppShell()[XUL +0x7113838]
#26: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*)[XUL +0x1066250]
#27: MessageLoop::RunInternal()[XUL +0xfd44a8]
#28: MessageLoop::Run()[XUL +0xfd43a0]
#29: XRE_InitChildProcess(int, char**, XREChildData const*)[XUL +0x711267c]
#30: main[plugin-container.app/Contents/MacOS/plugin-container +0x6cc]

So this is because ScriptLoader::InstantiateClassicScriptFromCachedStencil is instantiating cached InitialStencilAndDelazifications,
and the delazifications have been collected into it.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 2020531 - Move the eager baseline compilation option assertion to apply only to actual delazifications. r?denispal!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2d3552b21bc8
https://hg.mozilla.org/integration/autoland/rev/7f9786eb578b
Move the eager baseline compilation option assertion to apply only to actual delazifications. r=denispal

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e6cd9208fed0
https://hg.mozilla.org/integration/autoland/rev/c4918e1242cc
Revert "Bug 2020531 - Move the eager baseline compilation option assertion to apply only to actual delazifications. r=denispal" for causing multiple Delazifying related failures

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing multiple Delazifying related failures

Backout link

Push with failures

Comment 5

[Tooru Fujisawa [:arai]]

I forgot "IF" part of "MOZ_ASSERT_IF"

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0aee93e9e911
https://hg.mozilla.org/integration/autoland/rev/f8eca2dd4d02
Move the eager baseline compilation option assertion to apply only to actual delazifications. r=denispal

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f8eca2dd4d02