2020613 - XmitBufLock leak in dtls13_MaybeSendKeyUpdate

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Maurice Dauer [:mdauer]]

dtls13_MaybeSendKeyUpdate() in lib/ssl/dtls13con.c acquires XmitBufLock (line 820) but both error paths (lines 823, 830) return without releasing it, deadlocking subsequent sends.

ssl_GetXmitBufLock(ss);                          // acquired
rv = dtls13_EnqueueKeyUpdateMessage(ss, request);
if (rv != SECSuccess) {
    return rv;                                    // leaked
}
rv = ssl3_FlushHandshake(ss, 0);
if (rv != SECSuccess) {
    return SECFailure;                            // leaked
}
ssl_ReleaseXmitBufLock(ss);                       // success only

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 2020613 - release xmit buf lock on dtls13_MaybeSendKeyUpdate error paths. r=nkulatova

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/nss/rev/f3d098e87b2d
release xmit buf lock on dtls13_MaybeSendKeyUpdate error paths. r=nkulatova