2020626 - jpeg xl decoder should target the system cms profile

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, enhancement)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 2020626. Save the CMS output profile ICC bytes in the parent process and make it available for callers. r?#gfx-reviewers

The bytes get set in content processes because that is how we send the profile to them, but the parent process wasn't saving the bytes. We want access to the bytes for the jpeg xl decoder (jxl-rs tracks color space with a rust enum that's either simple common color spaces or a vec of icc bytes) so we can get jxl-rs to target our system output profile in the case it's not sRGB.

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 2020626. The jpeg xl decoder should target the system CMS profile. r?saschanaz

This tries not to create extra profiles or copies of icc bytes unless necessary. Having to pass stuff between C++ and rust makes this more annoying. This also handles the CMSMode::Off case. This turned out more finicky then I would have liked.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/36171157fad7
https://hg.mozilla.org/integration/autoland/rev/3cdba2636211
Save the CMS output profile ICC bytes in the parent process and make it available for callers. r=gfx-reviewers,lsalzman
https://github.com/mozilla-firefox/firefox/commit/64218171a702
https://hg.mozilla.org/integration/autoland/rev/d9a10538fdcc
The jpeg xl decoder should target the system CMS profile. r=saschanaz

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3cdba2636211
https://hg.mozilla.org/mozilla-central/rev/d9a10538fdcc