2020681 - More clean-ups after bug 2020358

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2020681 - More clean-ups after bug 2020358. r=masayuki,#dom-core

Move more text editor handling to the DOM, and remove more dead layout
code.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5a2bd42ae8af
https://hg.mozilla.org/integration/autoland/rev/003332e67faa
More clean-ups after bug 2020358. r=masayuki,dom-core

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/90af8fd3d444
https://hg.mozilla.org/integration/autoland/rev/2bab410ff6d2
Revert "Bug 2020681 - More clean-ups after bug 2020358. r=masayuki,dom-core" for causing mochitest failures

Comment 4

[Silaghi Andreea]

Backed out for causing mochitest failures
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug231389.html | The textarea's insertion point should be scrolled into view - didn't expect +0, but got it

Comment 5

[Emilio Cobos Álvarez [:emilio]]

That behavior now matches other browsers. We scroll into view on focus. Tweaked that test.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bdf597210ef1
https://hg.mozilla.org/integration/autoland/rev/4fd6a053e584
More clean-ups after bug 2020358. r=masayuki,dom-core

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/4fd6a053e584

Comment 8

[Florin Bilt]

(In reply to pstanciu from comment #7)

https://hg.mozilla.org/mozilla-central/rev/4fd6a053e584

Perfherder has detected a talos performance change from push 4fd6a053e5848cbd19e19a9e9caf9fd8ce4d1569.

No action is required from the author; this comment is provided for informational purposes only.

Improvement	Test	Platform	Options	Absolute values [old vs new]
5%	perf_reftest_singletons resize-lengthy-textarea.html (doc)	linux1804-64-shippable-qr	e10s fission stylo webrender	156.11 ms -> 148.16 ms

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.