2020953 - Tolerate %VERSION% as a CKEditor 4 version number in the compatibility hack

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Henri Sivonen (:hsivonen)]

Bug 2002481 added a compat hack for CKEditor 4. For the hack to activate, window.CKEDITOR.version must exist and must start with "4.".

In bug 2020668 comment 15, a case of CKEditor 4 without the build step that would replace %VERSION% with a version number has been reported.

We should tolerate %VERSION% as the version number (or drop the additional check beyond a magic class name).

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 2020953 - Tolerate %VERSION% as a CKEditor 4 version number in the compatibility hack.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a4fa43777529
https://hg.mozilla.org/integration/autoland/rev/8d698cfef09e
Tolerate %VERSION% as a CKEditor 4 version number in the compatibility hack. r=vhilla

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 543435

Comment 4

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/8d698cfef09e

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:hsivonen, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox149 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Donal Meehan [:dmeehan]]

:hsivonen, to add to Comment 5, could you also consider a release uplift request?

Comment 7

[Henri Sivonen (:hsivonen)]

Attachment: Manual test

Comment 8

[Henri Sivonen (:hsivonen)]

Attachment: Actual manual test

Comment 9

[Henri Sivonen (:hsivonen)]

Attachment: Bug 2020953 - Tolerate %VERSION% as a CKEditor 4 version number in the compatibility hack.

Original Revision: https://phabricator.services.mozilla.com/D285982

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: CKEditor 4 that has been deployed without the upstream-intended build step does not work in Firefox.

Also, bug 2020927 is on top of this one, and uplifting that one is more important.

• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Load the attachment named "Actual manual test" and observe in the console in dev tools that there is a warning "Altered iframe load event timing for compatibility with CKEditor 4’s browser detection" and there is a log line "EVENT".
• Risk associated with taking this patch: low
• Explanation of risk level: I have manually tested that properly-deployed CKEditor 4 (which needs the compat hack) and CKEditor 5 (which doesn't need the compat hack) work after this. I have reasoned from a properly-deployed CKEditor 5 demo that it uses different globals, so this is not supposed to break improperly-deployed CKEditor 5, either.
• String changes made/needed: None.
• Is Android affected?: yes

Comment 11

[Henri Sivonen (:hsivonen)]

Attachment: Bug 2020953 - Tolerate %VERSION% as a CKEditor 4 version number in the compatibility hack.

Original Revision: https://phabricator.services.mozilla.com/D285982

Comment 12

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: CKEditor 4 that has been deployed without the upstream-intended build step does not work in Firefox.

Also, bug 2020927 is on top of this one, and uplifting that one is more important.

• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Load the attachment named "Actual manual test" and observe in the console in dev tools that there is a warning "Altered iframe load event timing for compatibility with CKEditor 4’s browser detection" and there is a log line "EVENT".
• Risk associated with taking this patch: low
• Explanation of risk level: I have manually tested that properly-deployed CKEditor 4 (which needs the compat hack) and CKEditor 5 (which doesn't need the compat hack) work after this. I have reasoned from a properly-deployed CKEditor 5 demo that it uses different globals, so this is not supposed to break improperly-deployed CKEditor 5, either.
• String changes made/needed: None.
• Is Android affected?: yes

Comment 13

[Henri Sivonen (:hsivonen)]

Attachment: Bug 2020953 - Tolerate %VERSION% as a CKEditor 4 version number in the compatibility hack. r=vhilla

Comment 14

[Henri Sivonen (:hsivonen)]

Attachment: Bug 2020953 - Tolerate %VERSION% as a CKEditor 4 version number in the compatibility hack.

Original Revision: https://phabricator.services.mozilla.com/D285982

Comment 15

[Henri Sivonen (:hsivonen)]

Attachment: Bug 2020953 - Tolerate %VERSION% as a CKEditor 4 version number in the compatibility hack.

Original Revision: https://phabricator.services.mozilla.com/D285982

Comment 16

[Henri Sivonen (:hsivonen)]

The duplicate uplift requests are due to requesting uplift here first and then the uplifts requests in bug 2020927 depending on this change.

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/a0725f81431d
https://hg.mozilla.org/releases/mozilla-release/rev/1625b2059b0f

Comment 18

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/7d7ce17707df
https://hg.mozilla.org/releases/mozilla-beta/rev/ef3db2ff55e0