Closed Bug 2020954 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 58249 - Remove quotes from attr() type()

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
150 Branch
Tracking Status
firefox150 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 58249 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58249
Details from upstream follow.

moonira <moonira@google.com> wrote:

Remove quotes from attr() type()

There were few attr() tests added in commit [0] that use attr() with
type() wrapped inside quetes, this is invalid syntax, the correct
syntax is: \<attr-type> = type( \<syntax> ), no quotes inside type(),
see spec [1]

[0] https://github.com/web-platform-tests/wpt/commit/5f239560f50ba72ff2758f309a8630667f571465
[1] https://drafts.csswg.org/css-values-5/#attr-notation

Change-Id: Id3f2d1f57b8f3d2a3753011dce01dd5ef97fccd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7628699
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Munira Tursunova \<moonira@google.com>
Cr-Commit-Position: refs/heads/main@{#1593840}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Attached file Notable wpt changes
# CI Results Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 424 tests and 1 subtests ## Status Summary ### Firefox `OK` : 1[GitHub] 226[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] `PASS`: 17[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 77[GitHub] 5161[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 5295[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 5305[Gecko-android-em-14-x86_64-debug-geckoview] 5306[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] `FAIL`: 95[GitHub] 4303[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 4338[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 4339[Gecko-android-em-14-x86_64-debug-geckoview] 4350[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] ### Chrome `OK` : 1 `PASS`: 171 `FAIL`: 1 ### Safari `OK` : 1 `PASS`: 81 `FAIL`: 91 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=10e19295ba865263580f9478f909938384753f30) [GitHub PR Head](https://wpt.fyi/results/?sha=88fac3f57b7d893a7f67a9c5b7128840d57d9a9a&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=88fac3f57b7d893a7f67a9c5b7128840d57d9a9a&label=pr_base) ## Details (See attachment for full changes)
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: