2020992 - Video tag with object-fit and sizes defined are overflowed if `overflow:hidden` is defined

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Flo]

Attachment: bug.html

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:148.0) Gecko/20100101 Firefox/148.0

Steps to reproduce:

Styling the <video> tag by setting the dimensions (for example: height: 50vh;width: 100%;), an object-fit: cover, and an overflow:hidden displays the video AND the hidden part that should be cropped.

Actual results:

With the overflow:hidden property, the video is overflowed and the overflowed part is displaying behind the following HTML markup
Without the overflow:hidden it's ok.

Expected results:

The overflow:hidden crops the video correctly. This bug occurs since Firefox 148.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Jim Mathies [:jimm]]

Hey Daniel, trying to determine if this is css, media (video element) or rendering. Curious if you can help triage this one?

Comment 3

[Daniel Holbert [:dholbert]]

I think it belongs in Layout. mozregression indicates that this is a pretty recent regression, from emilio's work in bug 1999100:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c114ada67c791c6f24daacc33c6a6fe49efe430d&tochange=e81fe51adc7c48e454bc04b7d82a6cf2211ebe82

--> ni=emilio

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1999100

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2020992 - video should interpret scrollable overflow as clip. r=#layout

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6c21218849fa
https://hg.mozilla.org/integration/autoland/rev/11f9ca133080
video should interpret scrollable overflow as clip. r=layout-reviewers,dshin

Comment 7

[rperta]

https://hg.mozilla.org/mozilla-central/rev/11f9ca133080

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox149 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Trivial compat regression
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: comment 0
• Risk associated with taking this patch: low
• Explanation of risk level: One liner.
• String changes made/needed?: none
• Is Android affected?: yes

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2020992 - video should interpret scrollable overflow as clip.

Original Revision: https://phabricator.services.mozilla.com/D287950

Comment 11

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Trivial compat regression
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: comment 0
• Risk associated with taking this patch: low
• Explanation of risk level: One liner.
• String changes made/needed?: none
• Is Android affected?: yes

Comment 12

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2020992 - video should interpret scrollable overflow as clip.

Original Revision: https://phabricator.services.mozilla.com/D287950

Comment 13

[Donal Meehan [:dmeehan]]

Comment on attachment 9553636 [details]
Bug 2020992 - video should interpret scrollable overflow as clip.

Rejecting release uplift request. Fx149 merges to release tomorrow, we don't have a Fx148 dot release before then.

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2db61effcc57
https://hg.mozilla.org/releases/mozilla-beta/rev/d116c93d0929

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58576 for changes under testing/web-platform/tests

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 17

[Monica Chiorean]

Reproduced the issue on Win11x64/Ubuntu 24.04 using Firefox build 148.0.2
Verified as fixed on Win11x64/Ubuntu24.04 using Firefox builds 150.0a1.
Bug did not reached 149.0b9 as it is still reproducing and it got rejected based on comment#13.

Comment 18

[Monica Chiorean]

Verified issue as fixed on Ubuntu 24.04/Win11x64 using Firefox RC build 149.0(20260318190823).