Closed Bug 2021153 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 58268 - [Masonry] Handle dense packing in container-level baseline alignment

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
150 Branch
Tracking Flags:
Tracking Status
firefox150 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 58268 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58268
Details from upstream follow.

Yanling Wang <yanlingwang@microsoft.com> wrote:

[Masonry] Handle dense packing in container-level baseline alignment

This CL updates container-level baseline candidate selection in the
stacking axis to follow placement order in both normal and dense packing
based on the resolution of [1], which clarifies that negative margins
don't affect baselines, but dense-packing does. Because a track’s
running position never moves backward, it is used to determine which
item is treated as the first or last baseline candidate within each
track.

This also fixed the test column-grid-lanes-container-baseline-008.html,
which was disabled in CL:7585254

[1] https://github.com/w3c/csswg-drafts/issues/13165

Fixed: 479897631
Bug: 343257585
Change-Id: Ie73e4b9e4bc2e2eb2bcf261b764b6a7b248cad2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7604822
Commit-Queue: Yanling Wang \<yanlingwang@microsoft.com>
Reviewed-by: Celeste Pan \<celestepan@microsoft.com>
Reviewed-by: Alison Maher \<almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1594200}

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 40 tests

Status Summary

Firefox

FAIL: 4[GitHub] 40[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

PASS: 3
FAIL: 1

Safari

FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

https://hg.mozilla.org/mozilla-central/rev/615cce669010
https://hg.mozilla.org/mozilla-central/rev/ec14c0e28270

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox150: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
You need to log in before you can comment on or make changes to this bug.