2021163 - [wpt-sync] Sync PR 58271 - Use EqualIgnoringAsciiCase() in LookupAlgorithmIdByName()

Status: RESOLVED FIXED

(Core :: DOM: Web Crypto, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 58271 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58271
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Use EqualIgnoringAsciiCase() in LookupAlgorithmIdByName()

The "Normalizing an algorithm" algorithm[1] says that names should be
matched ASCII case-insensitive [2]. Currently the lookup sort of does
that, but the verifying comparison still uses a full Unicode
case-folding comparison. Because of how the lookup is structured the
lookup for some algorithm names could still accept non-ASCII.

Replace the final DeprecatedEqualIgnoringCase() comparison with
EqualIgnoringAsciiCase().

[1] https://w3c.github.io/webcrypto/#algorithm-normalization-normalize-an-algorithm
[2] https://w3c.github.io/webcrypto/#case-insensitive

Bug: 40476285
Change-Id: If1ee6a3c1e75f271c171b44f8de31fe688546b0c
Reviewed-on: https://chromium-review.googlesource.com/7633022
WPT-Export-Revision: d4ca285d7572b2d4ac6cc47d9e73195812329381

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a606cf8902b95851f126fd03ce23dfa5546eda07

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 4 subtests

Status Summary

Firefox

OK : 2
PASS: 8

Chrome

OK : 2
FAIL: 8

Safari

OK : 2
PASS: 8

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8051ff677f27
https://hg.mozilla.org/integration/autoland/rev/4d4df1acc91c
[wpt PR 58271] - Use EqualIgnoringAsciiCase() in LookupAlgorithmIdByName(), a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/4d4df1acc91c