2021199 - [wpt-sync] Sync PR 58277 - Fix broken image icon test for LCP

Status: RESOLVED FIXED

(Core :: DOM: Performance APIs, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 58277 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58277
Details from upstream follow.

Shubham Gupta <[e-mail]> wrote:

Fix broken image icon test for LCP

This was overlooked in ##58146.

We need to check the entryList and then check the filteredEntries.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 58277 applied with additional changes from upstream: a9ece78d02884cc04785a203ad9452247a90710f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3c9ace8157fe635558c64b24f906a1d5fa33b3a

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 67 tests and 1 subtests

Status Summary

Firefox

OK : 1[GitHub] 64[Gecko-linux2404-64-debug] 65[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
PASS : 1[GitHub] 105[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL : 9

Chrome

OK : 1
PASS : 1

Safari

PASS : 1
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /largest-contentful-paint/animated/observe-video.tentative.html [wpt.fyi]: SKIP
• /largest-contentful-paint/video-data-uri.html [wpt.fyi]: SKIP
• /largest-contentful-paint/animated/observe-animated-image-gif.tentative.html [wpt.fyi]
  • Same origin animated image is observable and has a first frame.: FAIL
• /largest-contentful-paint/animated/observe-animated-image-webp.tentative.html [wpt.fyi]
  • Same origin animated image is observable and has a first frame.: FAIL
• /largest-contentful-paint/animated/observe-animated-image.tentative.html [wpt.fyi]
  • Same origin animated image is observable and has a first frame.: FAIL
• /largest-contentful-paint/image-upscaling-empty-url.html [wpt.fyi]
  • A background image smaller than the container should report the natural size: FAIL
• /largest-contentful-paint/image-upscaling.html [wpt.fyi]
  • A background image smaller than the container should report the natural size: FAIL
• /largest-contentful-paint/initially-invisible-images.html [wpt.fyi]
  • Image visibility: out-of-viewport images are observable by LargestContentfulPaint once they become visible.: FAIL
• /largest-contentful-paint/loadTime-after-appendChild.html [wpt.fyi]: OK [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], SKIP [Gecko-linux2404-64-debug]
• /largest-contentful-paint/web-font-styled-text-resize-swap-after-interaction.html [wpt.fyi]
  • LCP should be not updated if the web font styled text resize occurs after an interaction happens: FAIL
• /largest-contentful-paint/web-font-styled-text-resize-swap-subnode.html [wpt.fyi]
  • LCP should be updated if the web font styled text resizes to be larger during the swap period: FAIL
• /largest-contentful-paint/web-font-styled-text-resize-swap.html [wpt.fyi]
  • LCP should be updated if the web font styled text resizes to be larger during the swap period: FAIL

Tests Disabled in Gecko Infrastructure

• /largest-contentful-paint/animated/observe-video.tentative.html [wpt.fyi]: SKIP
• /largest-contentful-paint/video-data-uri.html [wpt.fyi]: SKIP
• /largest-contentful-paint/loadTime-after-appendChild.html [wpt.fyi]: OK [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], SKIP [Gecko-linux2404-64-debug]

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fec93ce0d3be
https://hg.mozilla.org/integration/autoland/rev/be603d49f6ef
[wpt PR 58277] - Fix `broken-image-icon.html` test for LCP, a=testonly

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/be603d49f6ef