Closed Bug 2021226 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 58266 - [Masonry] Ensure min/max-content values are correctly invalidated when block size is dynamically changed

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox150 fixed)

Status:
RESOLVED FIXED
Milestone:
150 Branch
Tracking Flags:
Tracking Status
firefox150 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 58266 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58266
Details from upstream follow.

Celeste Pan <celestepan@microsoft.com> wrote:

[Masonry] Ensure min/max-content values are correctly invalidated when block size is dynamically changed

This change accounts for Grid-Lanes containers with items that have an
inline size dependent on block size. There are two places that we need
to pick up this dependency:

  1. After ComputeMinAndMaxContentContributionForSelf, where we check if
    an individual item has an inline size dependent on block size, and

  2. In ComputeMinMaxSizes, where we need to set the
    depends_on_block_constraints boolean in our result if any of the items
    in the container have inline sizes dependent on block sizes, so that we
    know if we need to invalidate the min/max-content calculation if the
    block size is changed.

This change also renames the variable is_parallel_with_track_direction
to be use_item_inline_contribution, which more correctly reflects its
usage in track sizing, which is that in columns, we'll want to use the
inline size of an item if it's NOT orthogonal, and in rows, we'll want
the inline size of an item if it IS orthogonal.

Bug: 343257585
Change-Id: Id9e3d41f2b029c20230748e5a76dce46c5098656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7595693
Reviewed-by: Alison Maher \<almaher@microsoft.com>
Commit-Queue: Celeste Pan \<celestepan@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1594124}

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 69 tests and 7 subtests

Status Summary

Firefox

OK : 1
PASS: 2[GitHub] 7[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 25[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL: 50

Chrome

FAIL: 2

Safari

PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b74e669c4243 https://hg.mozilla.org/integration/autoland/rev/41ae8051f2ac [wpt PR 58266] - [Masonry] Ensure min/max-content values are correctly invalidated when block size is dynamically changed, a=testonly

https://hg.mozilla.org/mozilla-central/rev/41ae8051f2ac

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox150: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
You need to log in before you can comment on or make changes to this bug.