Closed Bug 2021267 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 58283 - Payment Request: remove instructions

Tracking

()

Status:

RESOLVED FIXED

Milestone:

150 Branch

Tracking Flags:

Tracking

Status

firefox150

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

2 months ago

Sync web-platform-tests PR 58283 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58283
Details from upstream follow.

Marcos Caceres <caceres_m@apple.com> wrote:

Payment Request: remove instructions

As these are automated tests, we don't need instructions for users. Plus they were causing some issues with .bless() and the test runner on iOS.

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Component: web-platform-tests → DOM: Web Payments

Product: Testing → Core

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

2 months ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=df68581e771fc311fcb73d912c36d4b373dbaadc

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

2 months ago

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 33 tests

Status Summary

Firefox

OK : 4
FAIL : 17

Chrome

OK : 3
PASS : 7
FAIL : 10
ERROR: 1

Safari

OK : 4
PASS : 14
FAIL : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/payment-request/payment-request-abort-method.https.html [wpt.fyi]
- Throws if the promise [[state]] is not "interactive": FAIL
- Calling abort() multiple times is always a new object.: FAIL
- The same request cannot be shown multiple times.: FAIL
- Aborting a request before it is shown doesn't prevent it from being shown later.: FAIL
/payment-request/payment-request-canmakepayment-method.https.html [wpt.fyi]
- All methods are unsupported: FAIL
/payment-request/payment-request-show-method.https.html [wpt.fyi]
- If payment method consultation produces no supported method of payment, then return a promise rejected with a "NotSupportedError" DOMException.: FAIL

New Tests That Don't Pass

/payment-request/PaymentMethodChangeEvent/methodDetails-attribute.https.html [wpt.fyi]: SKIP
/payment-request/PaymentMethodChangeEvent/methodName-attribute.https.html [wpt.fyi]: SKIP
/payment-request/PaymentRequestUpdateEvent/constructor.http.html [wpt.fyi]: SKIP
/payment-request/PaymentRequestUpdateEvent/constructor.https.html [wpt.fyi]: SKIP
/payment-request/PaymentRequestUpdateEvent/updatewith-method.https.html [wpt.fyi]: SKIP
/payment-request/constructor_convert_method_data.https.html [wpt.fyi]: SKIP
/payment-request/delegate-request.https.sub.html [wpt.fyi]: SKIP
/payment-request/historical.https.html [wpt.fyi]: SKIP
/payment-request/idlharness.https.window.html [wpt.fyi]: SKIP
/payment-request/onpaymentmethodchange-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-is-showing.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-abort-method.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: OK)
- Throws if the promise [[state]] is not "interactive": FAIL (Chrome: PASS, Safari: PASS)
- Calling abort() multiple times is always a new object.: FAIL (Chrome: PASS, Safari: PASS)
- The same request cannot be shown multiple times.: FAIL (Chrome: PASS, Safari: PASS)
- Aborting a request before it is shown doesn't prevent it from being shown later.: FAIL (Chrome: PASS, Safari: PASS)
/payment-request/payment-request-canmakepayment-method.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: ERROR, Safari: OK)
- If payment method identifier are supported, resolve promise with true.: FAIL (Chrome: FAIL, Safari: PASS)
- If request.[[state]] is "created", then return a promise that resolves to true for known method.: FAIL (Chrome: FAIL, Safari: PASS)
- All methods are unsupported: FAIL (Chrome: PASS, Safari: PASS)
- Mix of supported and unsupported methods, at least one method is supported.: FAIL (Chrome: FAIL, Safari: PASS)
- If request.[[state]] is "interactive", then return a promise rejected with an "InvalidStateError" DOMException.: FAIL (Chrome: FAIL, Safari: PASS)
- If request.[[state]] is "closed", then return a promise rejected with an "InvalidStateError" DOMException.: FAIL (Chrome: FAIL, Safari: PASS)
/payment-request/payment-request-constructor-thcrash.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-constructor.https.sub.html [wpt.fyi]: SKIP
/payment-request/payment-request-ctor-currency-code-checks.https.sub.html [wpt.fyi]: SKIP
/payment-request/payment-request-ctor-pmi-handling.https.sub.html [wpt.fyi]: SKIP
/payment-request/payment-request-disallowed-when-hidden.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-hasenrolledinstrument-method-protection.tentative.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-hasenrolledinstrument-method.tentative.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: OK)
- hasEnrolledInstrument() resolves to false for unsupported payment methods.: FAIL (Chrome: PASS, Safari: FAIL)
- If request.[[state]] is "interactive", then return a promise rejected with an "InvalidStateError" DOMException.: FAIL (Chrome: FAIL, Safari: FAIL)
- If request.[[state]] is "closed", then return a promise rejected with an "InvalidStateError" DOMException.: FAIL (Chrome: FAIL, Safari: FAIL)
/payment-request/payment-request-id-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-insecure.http.html [wpt.fyi]: SKIP
/payment-request/payment-request-not-exposed.https.worker.html [wpt.fyi]: SKIP
/payment-request/payment-request-onshippingaddresschange-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-onshippingoptionchange-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-shippingAddress-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-shippingOption-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-shippingType-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-show-method.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: OK)
- Throws if the promise [[state]] is not 'created'.: FAIL (Chrome: FAIL, Safari: PASS)
- If the user agent's "payment request is showing" boolean is true, then return a promise rejected with an "AbortError" DOMException.: FAIL (Chrome: FAIL, Safari: PASS)
- If payment method consultation produces no supported method of payment, then return a promise rejected with a "NotSupportedError" DOMException.: FAIL (Chrome: PASS, Safari: PASS)
- Calling show() multiple times always returns a new promise.: FAIL (Chrome: FAIL, Safari: PASS)
/payment-request/payment-response/onpayerdetailchange-attribute.https.html [wpt.fyi]: SKIP
/payment-request/rejects_if_not_active.https.html [wpt.fyi]: SKIP
/payment-request/show-consume-activation.https.html [wpt.fyi]: SKIP
/payment-request/show-method-optional-promise-rejects.https.html [wpt.fyi]: SKIP

Tests Disabled in Gecko Infrastructure

/payment-request/PaymentMethodChangeEvent/methodDetails-attribute.https.html [wpt.fyi]: SKIP
/payment-request/PaymentMethodChangeEvent/methodName-attribute.https.html [wpt.fyi]: SKIP
/payment-request/PaymentRequestUpdateEvent/constructor.http.html [wpt.fyi]: SKIP
/payment-request/PaymentRequestUpdateEvent/constructor.https.html [wpt.fyi]: SKIP
/payment-request/PaymentRequestUpdateEvent/updatewith-method.https.html [wpt.fyi]: SKIP
/payment-request/constructor_convert_method_data.https.html [wpt.fyi]: SKIP
/payment-request/delegate-request.https.sub.html [wpt.fyi]: SKIP
/payment-request/historical.https.html [wpt.fyi]: SKIP
/payment-request/idlharness.https.window.html [wpt.fyi]: SKIP
/payment-request/onpaymentmethodchange-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-is-showing.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-abort-method.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: OK)
/payment-request/payment-request-canmakepayment-method.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: ERROR, Safari: OK)
/payment-request/payment-request-constructor-thcrash.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-constructor.https.sub.html [wpt.fyi]: SKIP
/payment-request/payment-request-ctor-currency-code-checks.https.sub.html [wpt.fyi]: SKIP
/payment-request/payment-request-ctor-pmi-handling.https.sub.html [wpt.fyi]: SKIP
/payment-request/payment-request-disallowed-when-hidden.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-hasenrolledinstrument-method-protection.tentative.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-hasenrolledinstrument-method.tentative.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: OK)
/payment-request/payment-request-id-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-insecure.http.html [wpt.fyi]: SKIP
/payment-request/payment-request-not-exposed.https.worker.html [wpt.fyi]: SKIP
/payment-request/payment-request-onshippingaddresschange-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-onshippingoptionchange-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-shippingAddress-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-shippingOption-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-shippingType-attribute.https.html [wpt.fyi]: SKIP
/payment-request/payment-request-show-method.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: OK)
/payment-request/payment-response/onpayerdetailchange-attribute.https.html [wpt.fyi]: SKIP
/payment-request/rejects_if_not_active.https.html [wpt.fyi]: SKIP
/payment-request/show-consume-activation.https.html [wpt.fyi]: SKIP
/payment-request/show-method-optional-promise-rejects.https.html [wpt.fyi]: SKIP

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Depends on: 2022568

Pulsebot

Comment 3

•

2 months ago

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/27a7bc453128 https://hg.mozilla.org/integration/autoland/rev/87c8a169d6fd [wpt PR 58283] - Payment Request: remove instructions, a=testonly

amarc

Comment 4

•

2 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/87c8a169d6fd

Status: NEW → RESOLVED

Closed: 2 months ago

status-firefox150: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 150 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 58283 - Payment Request: remove instructions

Categories

(Core :: DOM: Web Payments, task, P4)

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

Firefox-only Failures

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Updated

Comment 3

Comment 4