2021558 - Implement «Stop using “strictly split” in “validate and extract”» change to DOM spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[sideshowbarker [:sideshowbarker]]

Implement the DOM spec PR at https://github.com/whatwg/dom/pull/1455

Comment 1

[sideshowbarker [:sideshowbarker]]

Attachment: Bug 2021558 - Implement «Stop using “strictly split” in “validate and extract”» change to DOM spec, r=smaug,#dom-core

Change local-name computation in ParseQualifiedNameRelaxed to preserve
everything after the first colon in a qualified name — rather than, per
the spec’s “strictly split” algorithm, throwing away any other part of
the name after any second colon the name might have.

For the qualified name “f:o:o”, that now gives localName=“o:o”.
Otherwise, without this change, it would instead give localName=“o”.

See https://github.com/whatwg/dom/pull/1455

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f7b12313eddd
https://hg.mozilla.org/integration/autoland/rev/74080a29c686
Implement «Stop using “strictly split” in “validate and extract”» change to DOM spec, r=smaug,dom-core

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/33711e373cd1
https://hg.mozilla.org/integration/autoland/rev/04a605769415
Revert "Bug 2021558 - Implement «Stop using “strictly split” in “validate and extract”» change to DOM spec, r=smaug,dom-core" for causing mochitest plain failures on createAttributeNS01.html

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing mochitest plain failures on createAttributeNS01.html

Push with failures

Failure log:

• https://treeherder.mozilla.org/logviewer?job_id=552800655&repo=autoland&task=HD9yR_PxSYahFXcU5TvS6A.0

Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a6e86510c259
https://hg.mozilla.org/integration/autoland/rev/00c0d0b51187
Implement «Stop using “strictly split” in “validate and extract”» change to DOM spec, r=smaug,dom-core

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e008a154aa21
https://hg.mozilla.org/integration/autoland/rev/287dd0c88495
Revert "Bug 2021558 - Implement Stop using strictly split in validate and extract change to DOM spec, r=smaug,dom-core" for causing mochitests related failures at test_createDocument01.html

Comment 7

[rperta]

Backed out for causing mochitests related failures at test_createDocument01.html
Backout link
Push with failures
Failure log(s)

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

I guess the patch need rebasing or something. Couldn't land it.

Comment 9

[sideshowbarker [:sideshowbarker]]

(In reply to Olli Pettay [:smaug][[e-mail]] from comment #8)

I guess the patch need rebasing or something. Couldn't land it.

I rebased against trunk and re-pushed it. I don’t know what the problem was (is?) — there were no merge conflicts when I rebased it.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bcb3bc73c8a3
https://hg.mozilla.org/integration/autoland/rev/bca5cc762e77
Implement «Stop using “strictly split” in “validate and extract”» change to DOM spec, r=smaug,dom-core

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/37ede1d133c6
https://hg.mozilla.org/integration/autoland/rev/18d29edb5d0f
Remove DOMImplementation-createDocument.html.ini & Document-createElementNS.html.ini because wpt's pass now. r=smaug,sideshowbarker

Comment 12

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/bca5cc762e77
https://hg.mozilla.org/mozilla-central/rev/18d29edb5d0f