Closed
Bug 2021640
Opened 3 months ago
Closed
Use private class fields in devtools/client/netmonitor/src/connector/index.js
Categories
(DevTools :: Netmonitor, task)
DevTools
Netmonitor
Tracking
(firefox150 fixed)
RESOLVED
FIXED
150 Branch
| Tracking | Status | |
|---|---|---|
| firefox150 | --- | fixed |
People
(Reporter: cvl123abc, Assigned: cvl123abc)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/144.0.0.0 Safari/537.36
Steps to reproduce:
Reviewed devtools/client/netmonitor/src/connector/index.js and identified underscore-prefixed properties and methods that are used as private class members.
Actual results:
The file currently uses underscore-prefixed properties and methods to indicate privacy.
Expected results:
Use JavaScript private class fields and methods (#) instead of underscore-prefixed properties.
|
Assignee | |
Comment 1•3 months ago
|
||
I’m working on this as part of the ongoing private fields migration (meta bug 2011387).
|
|
Assignee | |
Comment 2•3 months ago
|
||
|
||
Updated•3 months ago
|
Assignee: nobody → cvl123abc
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by nchevobbe@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/6be35ddc3764
https://hg.mozilla.org/integration/autoland/rev/af6a82bfe927
Use private class fields in devtools/client/netmonitor/src/connector/index.js. r=nchevobbe,devtools-reviewers
|
||
Comment 4•3 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox150:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
|
|
||
Comment 5•3 months ago
|
||
| bugherder | ||
Closed: 3 months ago
|
||
Updated•2 months ago
|
QA Whiteboard: [qa-triage-done-c151/b150]
You need to log in
before you can comment on or make changes to this bug.
Description
•