Closed Bug 2021653 Opened 8 months ago Closed 8 months ago

[riscv64] Stylistic cleanup for RV64 backend

Categories

(Core :: JavaScript Engine: JIT, task)

RISCV64
Unspecified
task

Tracking

()

RESOLVED FIXED
150 Branch
Tracking Status
firefox150 --- fixed

People

(Reporter: csmantle, Assigned: csmantle)

References

(Blocks 1 open bug)

Details

Attachments

(7 external files)

The current RV64 implementation has multiple issues:

  • Redundant #includes, presumably copied verbatim from other files,
  • Mismatched parameter names between declaration and definition sites,
  • Bad naming convention, for example snake_case vs camelCase for methods,
  • Unused variables.

These are causing a lot of warnings in VSCode with default clang-tidy settings by ./mach ide vscode. We should try and clean these up.

The changes covered by this bug should not change runtime behavior.

Assignee: nobody → webmaster
Blocks: sm-riscv64
Status: NEW → ASSIGNED
Hardware: Unspecified → RISCV64
  • Assembler::instr_at_put -> Assembler::putInstrAt
  • Assembler::is_near -> Assembler::isNear
Attachment #9550769 - Attachment description: WIP: Bug 2021653 - [riscv64] Part 1: Match parameter names between defn and decl sites. r=jandem → Bug 2021653 - [riscv64] Part 2: Match parameter names between defn and decl sites. r=jandem
Attachment #9550770 - Attachment description: WIP: Bug 2021653 - [riscv64] Part 2: Fix brace problems reported by clang-tidy. r=jandem → Bug 2021653 - [riscv64] Part 3: Fix brace problems reported by clang-tidy. r=jandem
Attachment #9550771 - Attachment description: WIP: Bug 2021653 - [riscv64] Part 3: Use newline char instead of std::endl when writing to std::cout. r=jandem → Bug 2021653 - [riscv64] Part 4: Use newline char instead of std::endl when writing to std::cout. r=jandem
Attachment #9550772 - Attachment description: WIP: Bug 2021653 - [riscv64] Part 4: Remove definitely unused #include stmts from .cpp leaves. r=jandem → Bug 2021653 - [riscv64] Part 5: Remove definitely unused #include stmts from .cpp leaves. r=jandem
Attachment #9550773 - Attachment description: WIP: Bug 2021653 - [riscv64] Part 5: Wrap macro params in parentheses. r=jandem → Bug 2021653 - [riscv64] Part 6: Wrap macro params in parentheses. r=jandem
Attachment #9550774 - Attachment description: WIP: Bug 2021653 - [riscv64] Part 6: Add a const specifier as recommended by clang-tidy. r=jandem → Bug 2021653 - [riscv64] Part 7: Add a const specifier as recommended by clang-tidy. r=jandem

Reorganized patch dependency stack.

QA Whiteboard: [qa-triage-done-c151/b150]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: