[riscv64] Stylistic cleanup for RV64 backend
Categories
(Core :: JavaScript Engine: JIT, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox150 | --- | fixed |
People
(Reporter: csmantle, Assigned: csmantle)
References
(Blocks 1 open bug)
Details
Attachments
(7 external files)
The current RV64 implementation has multiple issues:
- Redundant
#includes, presumably copied verbatim from other files, - Mismatched parameter names between declaration and definition sites,
- Bad naming convention, for example snake_case vs camelCase for methods,
- Unused variables.
These are causing a lot of warnings in VSCode with default clang-tidy settings by ./mach ide vscode. We should try and clean these up.
The changes covered by this bug should not change runtime behavior.
| Assignee | ||
Updated•8 months ago
|
| Assignee | ||
Comment 1•8 months ago
|
||
| Assignee | ||
Comment 2•8 months ago
|
||
| Assignee | ||
Comment 3•8 months ago
|
||
| Assignee | ||
Comment 4•8 months ago
|
||
| Assignee | ||
Comment 5•8 months ago
|
||
| Assignee | ||
Comment 6•8 months ago
|
||
| Assignee | ||
Comment 7•8 months ago
|
||
- Assembler::instr_at_put -> Assembler::putInstrAt
- Assembler::is_near -> Assembler::isNear
Updated•8 months ago
|
Updated•8 months ago
|
Updated•8 months ago
|
Updated•8 months ago
|
Updated•8 months ago
|
Updated•8 months ago
|
| Assignee | ||
Comment 8•8 months ago
|
||
Reorganized patch dependency stack.
Comment 10•8 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b93a4f500446
https://hg.mozilla.org/mozilla-central/rev/2c4ce8062706
https://hg.mozilla.org/mozilla-central/rev/4c092b419f22
https://hg.mozilla.org/mozilla-central/rev/6ba4ef041e12
https://hg.mozilla.org/mozilla-central/rev/f0453d6e27f1
https://hg.mozilla.org/mozilla-central/rev/ebafb0332346
https://hg.mozilla.org/mozilla-central/rev/7ee6af0ebcd7
Comment 11•8 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b93a4f500446
https://hg.mozilla.org/mozilla-central/rev/2c4ce8062706
https://hg.mozilla.org/mozilla-central/rev/4c092b419f22
https://hg.mozilla.org/mozilla-central/rev/6ba4ef041e12
https://hg.mozilla.org/mozilla-central/rev/f0453d6e27f1
https://hg.mozilla.org/mozilla-central/rev/ebafb0332346
https://hg.mozilla.org/mozilla-central/rev/7ee6af0ebcd7
Updated•7 months ago
|
Description
•