Closed Bug 2021659 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 58336 - [gap-decorations] Suppress full effective gaps for flex containers

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
150 Branch
Tracking Flags:
Tracking Status
firefox150 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 58336 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58336
Details from upstream follow.

Javier Contreras <javiercon@microsoft.com> wrote:

[gap-decorations] Suppress full effective gaps for flex containers

This CL makes sure we suppress row and column gaps as per
https://github.com/w3c/csswg-drafts/issues/11520#issuecomment-2628423830.

This was already implemented for any gaps created by the gap
properties, in CL:6666279 and CL:6657779, but after
https://github.com/w3c/csswg-drafts/issues/12922#issuecomment-3814532173
it had to be extended to apply for the full effective gaps.

This involves any space between items/lines created by align-content
and justify-content.

We move effective_gap_between_lines to be passed around so that we are
able to use it in the fragmentation path for when we need it to be
suppressed.

We add the relevant tests for this, and adjust one test to account for
this new behavior as well.

Bug: 357648037, 394042462
Change-Id: I1aa9769dee6b9799bda6bf3a4a2374ab809e65cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7615749
Commit-Queue: Javier Contreras \<javiercon@microsoft.com>
Reviewed-by: Sam Davis Omekara \<samomekarajr@microsoft.com>
Reviewed-by: Alison Maher \<almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1595674}

Component: web-platform-tests → Layout
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 329 tests

Status Summary

Firefox

PASS: 11[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 184[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 210[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL: 7[GitHub] 118[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 119[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

FAIL: 7

Safari

FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

https://hg.mozilla.org/mozilla-central/rev/26bc718ae8d9
https://hg.mozilla.org/mozilla-central/rev/50f58fab26e7

Status: REOPENED → RESOLVED
Closed: 2 months ago → 2 months ago
status-firefox150: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
You need to log in before you can comment on or make changes to this bug.