2021681 - Page URL is displayed as tab name when page's <title> contains about:reader?

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Walter K.]

Attachment: test.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:148.0) Gecko/20100101 Firefox/148.0

Steps to reproduce:

Open any page that has about:reader? text in its <title> tag. See attached test file or bug 1550144.

Actual results:

Instead of page's title, tab shows its URL and Windows taskbar shows no title at all. Tab Manager list shows only URL as well. See image below.

Expected results:

The content of the <title> tag should be shown on the current tab and everywhere else page title is displayed

Comment 1

[Walter K.]

Attachment: title_is_not_displayed.png

This bug's tab title is missing too :)

Comment 2

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Jeremy Swinarton]

Looks like tabbrowser is being overly broad in what it considers to be a reader page: https://searchfox.org/firefox-main/source/browser/components/tabbrowser/content/tabbrowser.js#2196

A fix for this could include making this check more strict.

Comment 4

[Sayd Mateen]

Hi, Wanted to try to work on this bug for my first fix if no one else is working on it.

Comment 5

[Sayd Mateen]

Created PR: https://phabricator.services.mozilla.com/D289135

Comment 6

[Sayd Mateen]

Attachment: Bug 2021681 - Use precise regex to filter about:reader URLs in tab label ?

Comment 7

[Sayd Mateen]

Hi Kelly, I saw your comment about the incorrect bug ID. I went ahead and fixed it and resubmitted. I might have done it wrong because it created a new submission rather than updating existing one.

https://phabricator.services.mozilla.com/D289378

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e014172bc969
https://hg.mozilla.org/integration/autoland/rev/640075e8a488
Use precise regex to filter about:reader URLs in tab label ? r=tabbrowser-reviewers,jsudiaman

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/640075e8a488

Comment 10

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/640075e8a488