2021694 - Remove GetXULBoolAttr / GetXULAttr etc.

Status: RESOLVED FIXED

(Core :: XUL, task, P3)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2021694 - Remove GetXULBoolAttr. r=smaug

Three callers:

• fixed attribute is only used as fixed=true for treecolumns, so no
  behavior change.
• noautofocus is already only used as =true or removed, so no behavior
  change.
• incontentshell is only used with ="false", rename to noincontentshell
  for consistency with the other no* attributes in popups.

Remove the API and similar GetXUL* stuff that did the same.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2021694 - Fix a pre-existing disabled issue in GlobalKeyListener. r=#dom-core

Drive-by, but spotted while I looked for similar patterns. disabled was
converted to a regular bool attr a while ago in bug 2008041.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2021694 - Make other XUL frame attributes regular bool attrs. r=firefox-desktop-core-reviewers ,devtools-reviewers,tabbrowser-reviewers,layout-reviewers,geckoview-reviewers,whimboo,hiro,nchevobbe,sthompson,mossop

• primary and nodefaultsrc are already used as true or not present, so
  no behavior change.
• remote can be a regular XUL attr, but needs some consumers to change.

While at it remove the unused mozframetype attr, just use type for both
XUL and privileged iframes.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2021694 - Make noautohide a regular bool attr. r=aminomancer

FeatureCallout was the only front-end bit that was already not treating
it as such.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

FYI, might need minor thunderbird front-end changes.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0b6e678b0df6
https://hg.mozilla.org/integration/autoland/rev/f5095d952296
Fix a pre-existing disabled issue in GlobalKeyListener. r=dom-core,smaug

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f5095d952296

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4064391907f5
https://hg.mozilla.org/integration/autoland/rev/837d564dd29e
Make noautohide a regular bool attr. r=aminomancer,omc-reviewers,devtools-reviewers,nchevobbe

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d9f08ccbc61f
https://hg.mozilla.org/integration/autoland/rev/c37fa8ac7b55
Remove GetXULBoolAttr. r=smaug,devtools-reviewers,nchevobbe

Comment 10

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/837d564dd29e
https://hg.mozilla.org/mozilla-central/rev/c37fa8ac7b55

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/da15cdf74a9e
https://hg.mozilla.org/integration/autoland/rev/7c4c2112d403
Make other XUL frame attributes regular bool attrs. r=firefox-desktop-core-reviewers ,devtools-reviewers,tabbrowser-reviewers,layout-reviewers,geckoview-reviewers,whimboo,hiro,nchevobbe,sthompson,mossop

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9d9ea683566f
https://hg.mozilla.org/integration/autoland/rev/d12019413cd8
Revert "Bug 2021694 - Make other XUL frame attributes regular bool attrs. r=firefox-desktop-core-reviewers ,devtools-reviewers,tabbrowser-reviewers,layout-reviewers,geckoview-reviewers,whimboo,hiro,nchevobbe,sthompson,mossop" for causing bc failures @ browser_child_resource.js

Comment 13

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_child_resource.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d12019413cd8e91c09c36c2db5fc1e42a35c5cff

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | netwerk/test/browser/browser_child_resource.js | Browser should be in the right process - Got "", expected "true

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3234ef93471e
https://hg.mozilla.org/integration/autoland/rev/66d68383531a
Make other XUL frame attributes regular bool attrs. r=firefox-desktop-core-reviewers ,devtools-reviewers,tabbrowser-reviewers,layout-reviewers,geckoview-reviewers,whimboo,hiro,nchevobbe,sthompson,mossop ,devtools-reviewers,tabbrowser-reviewers,layout-reviewers,geckoview-reviewers,whimboo,hiro,nchevobbe,sthompson,mossop

Comment 15

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/66d68383531a

Comment 16

[Magnus Melin [:mkmelin]]

Thanks, just some minor c-c breakage.