2021715 - RFP: Return five touch points on Wayland when touch device is present

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Thorin [:thorin]]

see Bug 2020170

In Bug 1991701 we made Linux/Windows always reflect as touch capable, i.e 3 x window.Touch* properties are present and we reflected a hardcoded maxTouchPoints - just like a real touch device - see https://github.com/arkenfox/TZP/blob/2f52e2f9f106eec0d6e3973bbef3adf7943067c4/js/devices.js#L696-L740

on linux maxTouchPoints is was always 0 - there are one or two open bugzillas about it (probably totally related to X11), but I can't find them now

In order to stay benign with our spoofing, we should adjust our code to report 5 on linux wayland. It won't affect TB stable as we're on X11 until at least the next ESR (I assume), but this would be good to land now ahead of time.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

(In reply to Thorin [:thorin] from comment #0)

see Bug 2020170

In Bug 1991701 we made Linux/Windows always reflect as touch capable, i.e 3 x window.Touch* properties are present and we reflected a hardcoded maxTouchPoints - just like a real touch device - see https://github.com/arkenfox/TZP/blob/2f52e2f9f106eec0d6e3973bbef3adf7943067c4/js/devices.js#L696-L740

on linux maxTouchPoints is was always 0 - there are one or two open bugzillas about it (probably totally related to X11), but I can't find them now

In order to stay benign with our spoofing, we should adjust our code to report 5 on linux wayland. It won't affect TB stable as we're on X11 until at least the next ESR (I assume), but this would be good to land now ahead of time.

https://hg-edge.mozilla.org/mozilla-central/rev/14d0407ca9f6 reports five touch points.

Comment 2

[Pier Angelo Vendrame]

Sure, the change should be simple.
Last change to the spoofed value was on e89632384620be236889223ba0754b42093f30b3, but that commit didn't change any tests 🤷‍♀️.
I'll send a try build to check if it breaks anything. If it doesn't, we should add some tests.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Note that we report touch devices on Wayland only (not X11) while majority of Linux testing is sill on X11. Also we add the touch points only if any touch device is actually present.

Comment 4

[Pier Angelo Vendrame]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #3)

Note that we report touch devices on Wayland only (not X11) while majority of Linux testing is sill on X11. Also we add the touch points only if any touch device is actually present.

In RFP, we pretend all devices are touch capable, with the idea that usually sites don't force users to actually use touch.
So, we're already reporting the touch types that Firefox normally exposes only when touch devices are available.

Comment 5

[Thorin [:thorin]]

sites don't force users to actually use touch

only android exposes ontouch* properties (see https://github.com/arkenfox/TZP/blob/2f52e2f9f106eec0d6e3973bbef3adf7943067c4/js/devices.js#L696-L740) which is what websites use or get triggered by (at least in the past and referenced in ye olde bugzillas) - this is also what blink does

FYI: desktop blink regardless of touch capability always exposes 'Touch','TouchEvent','TouchList' window properties and the only thing they bother with is maxTouchPoints - whereas desktop gecko only exposes those three properties if actually touch capable

Comment 6

[Pier Angelo Vendrame]

Attachment: Bug 2021715 - Adjust the number of RFP spoofed touch points on Linux. r?#anti-tracking

Make it consistent with the number of touch points now reported on
Wayland when a touch device is available (see Bug 2020170).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/86a9fbe8d5ae
https://hg.mozilla.org/integration/autoland/rev/eb98aa72327c
Adjust the number of RFP spoofed touch points on Linux. r=timhuang

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/eb98aa72327c