2021892 - Make `navigator.permissions.query` aware of platform permission when appropriate

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Currently it fully depends on PermissionManager which is only aware of browser permissions, but it should return denied when OS denies the permission.

Comment 1

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 2021892 - Part 1: Make `navigator.permissions.query` aware of platform geolocation permission r=jjaschke

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2078a41b1b88
https://hg.mozilla.org/integration/autoland/rev/824de4fa09ba
Make `navigator.permissions.query` aware of platform geolocation permission r=jjaschke

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/40a731e04394
https://hg.mozilla.org/integration/autoland/rev/0757db69f359
Revert "Bug 2021892 - Make `navigator.permissions.query` aware of platform geolocation permission r=jjaschke" for causing mochitest failures.

Comment 4

[Goloman Adrian[:agoloman]]

Backed out for causing wpt and mochitest failures.

• Backout link
• Push with failures
• Failure Log mochitest
• Failure Log wpt

Comment 5

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 2021892 - Part 2: Fix test to wait for permission status r=jjaschke

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/14315fb2d25b
https://hg.mozilla.org/integration/autoland/rev/449b238627e4
Part 1: Make `navigator.permissions.query` aware of platform geolocation permission r=jjaschke
https://github.com/mozilla-firefox/firefox/commit/ee5f49fb8b1e
https://hg.mozilla.org/integration/autoland/rev/0bef0a15df9b
Part 2: Fix test to wait for permission status r=jjaschke

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/449b238627e4
https://hg.mozilla.org/mozilla-central/rev/0bef0a15df9b

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8a8736b70eea
https://hg.mozilla.org/integration/autoland/rev/9253acfa52c5
Revert "Bug 2021892 - Part 2: Fix test to wait for permission status r=jjaschke" for causing bug 2023331

Comment 9

[amarc]

backed out for causing bug 2023331: https://hg.mozilla.org/integration/autoland/rev/9253acfa52c5

Comment 10

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Should probably use PBackground instead for worker usage, PContent only supports main thread.

Comment 11

[Silaghi Andreea]

Backout merged to central https://hg-edge.mozilla.org/mozilla-central/rev/9253acfa52c54a538d65a51fee5e30fe2b14d6fa

Comment 12

[David Parks [:handyman]]

Attachment: Bug 2021892 - Part 3: Make storage-access get permission in workers r=jjaschke!,saschanaz!

Issues navigator.permissions.query, for currently supported and unsupported
permissions, from a web worker. This checks that the call is thread safe
for workers.

Comment 13

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 2021892 - Part 3: Add crashtest for permission query r=jjaschke

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bfb0da0bb587
https://hg.mozilla.org/integration/autoland/rev/e8a04d7e8811
Part 1: Make `navigator.permissions.query` aware of platform geolocation permission r=jjaschke
https://github.com/mozilla-firefox/firefox/commit/056bfc9b6f56
https://hg.mozilla.org/integration/autoland/rev/8641863e8aa2
Part 2: Fix test to wait for permission status r=jjaschke
https://github.com/mozilla-firefox/firefox/commit/97f45a358e5a
https://hg.mozilla.org/integration/autoland/rev/40098e1b94b1
Part 3: Add crashtest for permission query r=jjaschke

Comment 15

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e8a04d7e8811
https://hg.mozilla.org/mozilla-central/rev/8641863e8aa2
https://hg.mozilla.org/mozilla-central/rev/40098e1b94b1

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/59177 for changes under testing/web-platform/tests

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 18

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 2021892 - Part 1: Make `navigator.permissions.query` aware of platform geolocation permission

Original Revision: https://phabricator.services.mozilla.com/D286979

Comment 19

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 2021892 - Part 2: Fix test to wait for permission status

Original Revision: https://phabricator.services.mozilla.com/D287452

Comment 20

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 2021892 - Part 3: Add crashtest for permission query

Original Revision: https://phabricator.services.mozilla.com/D292777

Comment 21

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: People who granted geolocation permission in Google Maps but have not granted system permission to Firefox will get system prompt whenever they visit Google. See bug 2034518.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Please follow https://bugzilla.mozilla.org/show_bug.cgi?id=2034518#c0.
• Risk associated with taking this patch: low
• Explanation of risk level: Has already been in nightly and beta, the logic is relatively simple.
• String changes made/needed?: N/A
• Is Android affected?: no

Comment 22

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Henrik, you may also want to uplift the remote pref patch (and for macOS one too, we want to uplift that too).

Comment 23

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9c385a7f4472
https://hg.mozilla.org/releases/mozilla-release/rev/a0c82e98a369
https://github.com/mozilla-firefox/firefox/commit/8bd9b4700664
https://hg.mozilla.org/releases/mozilla-release/rev/2ba2b5d45fa0
https://github.com/mozilla-firefox/firefox/commit/906b61d64b7e
https://hg.mozilla.org/releases/mozilla-release/rev/a4bcc25118ab

Comment 24

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The patch on bug 2031230 was already uplifted. Thank you for letting us know Kagami!

Comment 25

[Simona Badau, Desktop Test Engineering]

Attachment: Screenshot with the Location permission on Ubuntu 24.04

Reproduced the initial issues as described in Bug 2034518 Comment 0 using Nightly 151.0a1 (Build ID: 20260406213346) - system prompt and browser permission was requested when visiting Google.com.

Verified as fixed using Firefox 151.0b2 on Windows 11 and macOS 15 where the system prompt and the browser permissions were no longer requested when navigating to Google.com after accessing and giving browser permissions on Google maps.

However, I noticed that when using Firefox 151.0b2 on Ubuntu 24.04 - the Location permission is still visible in the Address Bar when navigating to Google.com after accessing and giving permissions on Google maps - please see the screenshot.

@Kagami Rosylight, is this behavior expected on Ubuntu 24.04? Could you please take a look?

Comment 26

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

We don't follow system permission on Linux right now, so it's expected currently. Thanks!

Edit: bug 2035203.

Comment 27

[Simona Badau, Desktop Test Engineering]

(In reply to Kagami Rosylight [:saschanaz] (they/them) from comment #26)

We don't follow system permission on Linux right now, so it's expected currently. Thanks!

Thank you !
Based on this and on Comment 25, I'm setting the status for firefox151 to verified.

Comment 28

[Simona Badau, Desktop Test Engineering]

Verified as fixed using Firefox 150.0.1 (Build ID: 20260427013024) on Windows 11 and macOS 15 - system prompt and the browser permissions are no longer requested when navigating to Google.com after accessing and giving browser permissions on Google maps.