2021913 - Mlkem768x25519ShareDamager intermittent failures

Status: RESOLVED FIXED

(NSS :: Test, defect, P3)

Description

[John Schanck [:jschanck]]

Example log output:

[task 2026-03-06T23:29:05.064+00:00] [ RUN      ] TlsMlkem768x25519DamageTest/TlsMlkem768x25519DamageTest.DamageClientShare/5
[task 2026-03-06T23:29:05.064+00:00] Version: TLS 1.3
[task 2026-03-06T23:29:05.064+00:00] server: Changing state from INIT to CONNECTING
[task 2026-03-06T23:29:05.064+00:00] client: Changing state from INIT to CONNECTING
[task 2026-03-06T23:29:05.064+00:00] extension old: [1258] 04e8001d0020f84685c82e7897fb123b5c5a219a7e459f54f2b76385bb1c9046...
[task 2026-03-06T23:29:05.064+00:00] extension new: [1258] 04e8001d0020f84685c82e7897fb123b5c5a219a7e459f54f2b76385bb1c9046...
[task 2026-03-06T23:29:05.064+00:00] handshake old: [1386] 0303b19ebe4735e72327bd5142e0bb708fefd669f7167d6352c0f5dd96528a0b...
[task 2026-03-06T23:29:05.064+00:00] handshake new: [1386] 0303b19ebe4735e72327bd5142e0bb708fefd669f7167d6352c0f5dd96528a0b...
[task 2026-03-06T23:29:05.064+00:00] record old: [1390] 0100056a0303b19ebe4735e72327bd5142e0bb708fefd669f7167d6352c0f5dd...
[task 2026-03-06T23:29:05.064+00:00] record new: [1390] 0100056a0303b19ebe4735e72327bd5142e0bb708fefd669f7167d6352c0f5dd...
[task 2026-03-06T23:29:05.064+00:00] client: Filtered packet: [1395] 160301056e0100056a0303b19ebe4735e72327bd5142e0bb708fefd669f7167d...
[task 2026-03-06T23:29:05.064+00:00] server: Fatal alert sent: 47
[task 2026-03-06T23:29:05.064+00:00] d:\task_177283899237856\nss\gtests\ssl_gtest\tls_agent.cc(960): error: Expected equality of these values:
[task 2026-03-06T23:29:05.064+00:00]   expected
[task 2026-03-06T23:29:05.064+00:00]     Which is: '\x14' (20)
[task 2026-03-06T23:29:05.064+00:00]   alert->description
[task 2026-03-06T23:29:05.064+00:00]     Which is: '/' (47, 0x2F)
[task 2026-03-06T23:29:05.064+00:00] server: Handshake failed with error SEC_ERROR_INVALID_ARGS: security library: invalid arguments.
[task 2026-03-06T23:29:05.064+00:00] server: Changing state from CONNECTING to ERROR
[task 2026-03-06T23:29:05.064+00:00] client: Fatal alert received: 47
[task 2026-03-06T23:29:05.064+00:00] d:\task_177283899237856\nss\gtests\ssl_gtest\tls_agent.cc(960): error: Expected equality of these values:
[task 2026-03-06T23:29:05.064+00:00]   expected
[task 2026-03-06T23:29:05.064+00:00]     Which is: '\0'
[task 2026-03-06T23:29:05.064+00:00]   alert->description
[task 2026-03-06T23:29:05.064+00:00]     Which is: '/' (47, 0x2F)
[task 2026-03-06T23:29:05.064+00:00] d:\task_177283899237856\nss\gtests\ssl_gtest\tls_agent.cc(961): error: Expected equality of these values:
[task 2026-03-06T23:29:05.064+00:00]   expected_level
[task 2026-03-06T23:29:05.064+00:00]     Which is: '\x1' (1)
[task 2026-03-06T23:29:05.064+00:00]   alert->level
[task 2026-03-06T23:29:05.064+00:00]     Which is: '\x2' (2)
[task 2026-03-06T23:29:05.064+00:00] client: Handshake failed with error SSL_ERROR_ILLEGAL_PARAMETER_ALERT: SSL peer rejected a handshake message for unacceptable content.
[task 2026-03-06T23:29:05.064+00:00] client: Changing state from CONNECTING to ERROR
[task 2026-03-06T23:29:05.064+00:00] d:\task_177283899237856\nss\gtests\ssl_gtest\tls_agent.cc(916): error: Expected equality of these values:
[task 2026-03-06T23:29:05.064+00:00]   expected
[task 2026-03-06T23:29:05.064+00:00]     Which is: -12273
[task 2026-03-06T23:29:05.064+00:00]   error_code_
[task 2026-03-06T23:29:05.064+00:00]     Which is: -12226
[task 2026-03-06T23:29:05.064+00:00] Got error code SSL_ERROR_ILLEGAL_PARAMETER_ALERT expecting SSL_ERROR_BAD_MAC_READ
[task 2026-03-06T23:29:05.064+00:00] 
[task 2026-03-06T23:29:05.064+00:00] d:\task_177283899237856\nss\gtests\ssl_gtest\tls_agent.cc(916): error: Expected equality of these values:
[task 2026-03-06T23:29:05.064+00:00]   expected
[task 2026-03-06T23:29:05.064+00:00]     Which is: -12273
[task 2026-03-06T23:29:05.064+00:00]   error_code_
[task 2026-03-06T23:29:05.064+00:00]     Which is: -8187
[task 2026-03-06T23:29:05.064+00:00] Got error code SEC_ERROR_INVALID_ARGS expecting SSL_ERROR_BAD_MAC_READ
[task 2026-03-06T23:29:05.064+00:00] 
[task 2026-03-06T23:29:05.064+00:00] d:\task_177283899237856\nss\gtests\ssl_gtest\tls_agent.cc(117): error: Failed
[task 2026-03-06T23:29:05.064+00:00] Wrong expected_sent_alert status: client
[task 2026-03-06T23:29:05.064+00:00] [  FAILED  ] TlsMlkem768x25519DamageTest/TlsMlkem768x25519DamageTest.DamageClientShare/5, where GetParam() = 5 (5 ms)

The test will occasionally flip a public key bit and cause the corresponding coefficient to exceed the modulus. This causes intermittent test failures due to the public key validation steps added in the final ML-KEM specification.

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 2021913 - fix Mlkem768x25519ShareDamager intermittent CI failures. r=#nss-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/nss/rev/fc65590c0482
fix Mlkem768x25519ShareDamager intermittent CI failures. r=nss-reviewers,djackson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/nss/rev/ea5f47fda9b2
clang format.

Comment 4

[John Schanck [:jschanck]]

Attachment: Bug 2021913 - clang format. r=#nss-reviewers

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)