Closed Bug 2021973 Opened 5 months ago Closed 3 months ago

implement "Search With" submenu for Smartbar CTA button dropdown

Categories

(Core :: Machine Learning: Frontend, enhancement, P1)

Product:
Core
Component:
Machine Learning: Frontend
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
152 Branch
Iteration:
151.2 - April 6 - April 17
Tracking Flags:
Tracking Status
firefox150 --- wontfix
firefox151 + verified
firefox152 --- verified

People

(Reporter: dmosedale, Assigned: pdahiya)

References

(
URL
)

Details

(Whiteboard: [genai][input])

Attachments

(2 files)

Bug 2021973 - Smartbar inputCTA Search with submenu
48 bytes, text/x-phabricator-request
Details | Review
Bug 2021973 - Smartbar inputCTA Search with submenu
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review

Implement the "Search With" submenu for Smartbar CTA button dropdown.

Acceptance criteria look something like this:

  • dropdown of available search engines is implemented as per this and left-adjacent figma mocks
  • clicking on one of these behaves analogously to the existing "Search with Google" (or whatever the default engine is).
No longer blocks: style-smartbar-list
Assignee: nobody → pdahiya
Iteration: --- → 151.2 - April 6 - April 17
Priority: -- → P1
Attachment #9567317 - Attachment description: WIP: Bug 2021973 - Smartbar inputCTA Search with submenu → Bug 2021973 - Smartbar inputCTA Search with submenu
Blocks: 2033844
Pushed by pdahiya@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/dc13dd247d34 https://hg.mozilla.org/integration/autoland/rev/18516f66d860 Smartbar inputCTA Search with submenu r=desktop-theme-reviewers,urlbar-reviewers,ai-frontend-reviewers,fluent-reviewers,mak,Mardak,bolsson,Itiel

https://hg.mozilla.org/mozilla-central/rev/18516f66d860

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch

[Tracking Requested - why for this release]:
Smartbar Search Feature aiming Fx151

tracking-firefox151: --- → ?
Flags: qe-verify+

NI QA to help verify fix in Nightly Fx152 Thanks!

Flags: needinfo?(rdoghi)

:pdahiya, this will need a beta uplift request

tracking-firefox151: ? → +
Flags: needinfo?(pdahiya)

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Unavailable Smartbar Search With Submenu in Fx 151
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: In patch test plan https://phabricator.services.mozilla.com/D292548
  • Risk associated with taking this patch: low
  • Explanation of risk level: Enhancement to Smartbar input button shown only for Smart Window users
  • String changes made/needed?: English only preview file
  • Is Android affected?: no
Attachment #9573705 - Flags: approval-mozilla-beta?

Uplift requested after dev testing in Nightly and local Beta

Flags: needinfo?(pdahiya)
Attachment #9573705 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [uplift][qa-ver-needed-c152/b151]

Verified as fixed in our latest Beta 151.0b3 and our latest Nightly 152.0a1 (2026-04-26)

status-firefox150: --- → affected
status-firefox151: fixed → verified
status-firefox152: fixed → verified
Flags: needinfo?(rdoghi)
QA Contact: rdoghi

Updating the main status flag.

Status: RESOLVED → VERIFIED
QA Whiteboard: [uplift][qa-ver-needed-c152/b151] → [uplift][qa-ver-done-c152/b151]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: