Closed Bug 2022157 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 58372 - [focusgroup] Ensure popup buttons are have their role inferred.

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
150 Branch
Tracking Status
firefox150 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 58372 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58372
Details from upstream follow.

Jacques Newman <janewman@microsoft.com> wrote:

[focusgroup] Ensure popup buttons are have their role inferred.

crrev.com/c/7615549 didn't consider popup buttons for role inference. In
any of the focusgroup behaviors that infer roles, the child role
inference would be a richer role than a popup button, so role inference
should be applied.

Bug: 40210717
Change-Id: Ia93ddb2ecb710d308464597596f075b2ceafa9a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7634988
Reviewed-by: Mason Freed \<masonf@chromium.org>
Commit-Queue: Jacques Newman \<janewman@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1596611}

PR 58372 applied with additional changes from upstream: 22a45149263521735fec1f154ac777a61d958ac9
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 101 tests and 3 subtests

Status Summary

Firefox

OK : 1[GitHub] 101[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
PASS: 5[GitHub] 77[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL: 15[GitHub] 184[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

OK : 1
PASS: 15
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
You need to log in before you can comment on or make changes to this bug.