2022281 - action.openPopup() should reject if another panel or context menu is open

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Rob Wu [:robwu]]

To avoid disrupting or confusing the user, the action.openPopup() method should reject the request if other UI is floating around in the window.

We already check that for extension-generated panels, but it makes sense to extend this to other UI, notably context menus, doorhangers and notifications.

The existing error message was intentionally chosen to allow for this possibility, "openPopup() cannot be called while another panel is open".

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 2022281 - Reject openPopup() when other panels are open

Comment 2

[Rob Wu [:robwu]]

Marking as blocker of bug 1799344 to signal that the behavior here is intended to be the behavior of action.openPopup() when the ability to call it without user interaction ships to release for the first time.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d6f7c5697d46
https://hg.mozilla.org/integration/autoland/rev/0dadd7b0bf7d
Reject openPopup() when other panels are open r=rpl

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0dadd7b0bf7d

Comment 5

[Rob Wu [:robwu]]

Attachment: Bug 2022281 - Reject openPopup() when other panels are open (149 port)

On top of the original revision, this also includes a hidden pref
(extensions.openPopup.undoBug2022281) to allow users to undo the
change if they encounter an issue for any reason.

Original Revision: https://phabricator.services.mozilla.com/D286943

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Bug 1799344, riding the 149 train, dropped the user interaction requirement for the action.openPopup() method, which allows extensions to open the extension popup at any time. To prevent it from being disruptive or abused, this patch rejects the API call if a menu or panel is open.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: In theory, extensions could see their attempt to call action.openPopup() fail more often (with user gesture, which existed before 149), if there is other UI in the way (e.g. a doorhanger). As a work-around, users can manually click on the extension button to open its popup. Or if that does not work for any reason, they can temporarily opt out of the tighter restrictions (for 149) by setting the extensions.openPopup.undoBug2022281 pref to true.
• String changes made/needed: No
• Is Android affected?: no

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/86b56c25b333
https://hg.mozilla.org/releases/mozilla-beta/rev/2e395ebf0c6c