[wpt-sync] Sync PR 58393 - Preserve pointer metadata and isTrusted for label-forwarded clicks
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox150 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 58393 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/58393
Details from upstream follow.
Peng Zhou <pengzhou@chromium.org> wrote:
Preserve pointer metadata and isTrusted for label-forwarded clicks
Clicks forwarded from
\<label>to its associated control are
synthesized inSimulatedEventUtil. For kFromUserAgent pointer clicks,
we were not propagating pointer metadata from the underlying
PointerEvent, and forwarded clicks could be marked trusted even when
the underlying click was untrusted (e.g.label.click).Update simulated pointer click creation to:
- default to a non-pointer reserved
pointerId;- copy
pointerId,pointerType,isPrimary, anddetailfrom the
underlyingPointerEventwhen available;- mark the event trusted for
kFromUserAgentonly when there is no
underlying event or the underlying event itself is trusted.Bug: 450581754
Change-Id: I3fec917181566c7c9ed469475b8ab0fdedcc2f33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7640679
Reviewed-by: Kevin Ellis \<kevers@chromium.org>
Commit-Queue: Peng Zhou \<pengzhou@chromium.org>
Commit-Queue: Mustaq Ahmed \<mustaq@chromium.org>
Reviewed-by: Mustaq Ahmed \<mustaq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1597108}
|
Assignee | |
Updated•2 months ago
|
|
|
Assignee | |
Comment 1•2 months ago
|
||
|
|
Assignee | |
Comment 2•2 months ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 11 tests and 4 subtests
Status Summary
Firefox
OK : 1[GitHub] 11[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
PASS: 2[GitHub] 150[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL: 9
Chrome
OK : 1
FAIL: 2
Safari
OK : 1
FAIL: 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /html/semantics/forms/the-label-element/clicking-interactive-content.html [wpt.fyi]
- interactive content <audio controls=""></audio> as second child under <label>:
FAIL - interactive content <textarea></textarea> as first child of <label>:
FAIL - interactive content <textarea></textarea> deeply nested under <label>:
FAIL - interactive content <textarea></textarea> as second child under <label>:
FAIL - interactive content <video controls=""></video> as second child under <label>:
FAIL
- interactive content <audio controls=""></audio> as second child under <label>:
- /html/semantics/forms/the-label-element/clicking-noninteractive-unlabelable-content.html [wpt.fyi]
- noninteractive unlabelable content <object usemap=""></object> as second child under <label>:
FAIL
- noninteractive unlabelable content <object usemap=""></object> as second child under <label>:
- /html/semantics/forms/the-label-element/proxy-modifier-click-to-associated-element.tentative.html [wpt.fyi]
- label with for attribute should proxy click events to the associated element on shift click:
FAIL - label with for attribute should proxy click events to the associated element on alt click:
FAIL - label with for attribute should proxy click events to the associated element on meta click:
FAIL
- label with for attribute should proxy click events to the associated element on shift click:
Description
•