2022311 - Disable "Ask LLM" on document PiP and maybe popups

Status: RESOLVED FIXED

(Core :: Machine Learning: Frontend, enhancement)

Description

[Vincent Hilla [:vhilla]]

mconley pointed out to us that "Ask ChatGPT" and similar context menu entries don't work for Document Picture-in-Picture windows and popups.

Document PiP use cases like floating media players don't really make sense with LLM integration, I'm less sure about popups. It should be simple to disable such context menu entries based on browsingContext.isDocumentPiP or on being a popup. If desired, I can file a follow-up to make the sidebar work with popups.

Example: https://bug2008334.bmoattachments.org/attachment.cgi?id=9535360

Comment 1

[Vincent Hilla [:vhilla]]

( I don't think this is a high priority, I'll look into a patch tomorrow )

Comment 2

[Vincent Hilla [:vhilla]]

Attachment: Bug 2022311 - Disable Ask Chat Menu on popups. r=edgar,#firefox-ai-ml-reviewers

Comment 3

[Vincent Hilla [:vhilla]]

https://treeherder.mozilla.org/jobs?repo=try&revision=c2ade7484c223d287112a62d57d84d70ddc149cc

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ba8d76dc9cbe
https://hg.mozilla.org/integration/autoland/rev/470e9557b24d
Disable Ask Chat Menu on popups. r=edgar,ai-frontend-reviewers

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/470e9557b24d