2022398 - Remove old search engine XUL table after accessibility review comments have been addressed for moz-box-group

Status: NEW

(Firefox :: Settings UI, task, P2)

Description

[Stephanie Cunnane [:scunnane]]

Due to some accessibility concerns about the moz-box-group that is present on about:preferences#search when the SRD pref is true, we've decided to leave the old XUL search shortcut table in the code for now, so that those affected by any accessibility issues can set the SRD pref to false and continue unaffected. Once the moz-box-group accessibility issues have been addressed, I will remove the old XUL table. This includes:

• removal of the old XUL markup in search.inc.xhtml
• removal of the EngineStore and EngineView classes that manipulate the XUL table
• removal of the inProgress flag for this SRD card
• cleanup of old Fluent strings. When we ported the XUL search shortcut table over to the new moz-box-group, the buttons beneath the XUL table were removed, as well as the "Find more search engines" link. We should also remove the Fluent strings associated with those removals.
• cleanup of tests. The test changes to land for bug 2013057 are designed to work whether the SRD pref is true or false. But once we get rid of the XUL table and the SRD pref is true by default, we can back out certain test changes, as the tests no longer need to cover the XUL table.