Closed Bug 2022404 Opened 8 months ago Closed 8 months ago

Use private class fields in devtools/client/framework/devtools-browser.js

Categories

(DevTools :: Framework, task)

task

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: cvl123abc, Unassigned)

References

(Depends on 1 open bug)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/144.0.0.0 Safari/537.36

Steps to reproduce:

Reviewed devtools/client/framework/devtools-browser.js and identified underscore-prefixed properties and methods that are used as private class members.

Actual results:

The file currently uses underscore-prefixed properties and methods to indicate privacy.

Expected results:

Use JavaScript private class fields and methods (#) instead of underscore-prefixed properties.

Depends on: 2011387

I’m working on this as part of the ongoing private fields migration (meta bug 2011387).

This file is not using a class, but an object literal singleton, so it can't be converted to private class fields without a larger refactor. Skipping this file for the private class fields cleanup.

Status: UNCONFIRMED → RESOLVED
Closed: 8 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.